Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unclear comment for makeSpoofClient() arg #2347

Merged
merged 1 commit into from
Nov 11, 2021
Merged

Remove unclear comment for makeSpoofClient() arg #2347

merged 1 commit into from
Nov 11, 2021

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Nov 11, 2021

This patch makes a tiny change to remove unclear comment for makeSpoofClient() arg.

The timeout arg is not bool but time.Duration so this comment is confusing.

/cc @shinigambit

@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 11, 2021
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/test-and-release approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 11, 2021
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #2347 (771ae1d) into main (91d1932) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2347      +/-   ##
==========================================
+ Coverage   64.53%   64.55%   +0.02%     
==========================================
  Files         226      226              
  Lines        9668     9668              
==========================================
+ Hits         6239     6241       +2     
+ Misses       3154     3153       -1     
+ Partials      275      274       -1     
Impacted Files Coverage Δ
test/request.go 0.00% <0.00%> (ø)
test/gcs/mock/mock.go 92.47% <0.00%> (+1.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91d1932...771ae1d. Read the comment docs.

Copy link
Contributor

@markusthoemmes markusthoemmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 11, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markusthoemmes, nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nak3
Copy link
Contributor Author

nak3 commented Nov 11, 2021

/retest

@knative-prow-robot knative-prow-robot merged commit 0b0c339 into knative:main Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants