Add SinkCACerts to SourceStatus

[Rahul-Kumar-prog]

Fixes #2732
Added SinkCACerts to source status

Proposed Changes

• 🎁 Add new feature
• Added support for storing the CA certs of the resolved sink's destination

/kind feature

Add SinkCACerts to SourceStatus

SinkCACerts are certification authority CA certificates in the SourceStatus. so that we store the CA certs of the resolved sink's destination.

Reason to Implement SinkCACerts because :
currently, the addressable contract provides a single HTTP(s) URL.
HTTPS endpoints with certificates signed by cluster internal certification author (CA) need to provide the CA certificates so that clients can call HTTPS addressables without disabling client side certificates checks.

The new addressable contract will have an additional CACerts field to allow Addressable resources (Broker, Channel, and Sinks) to provide their CA certificates.

Addressable provides a generic mechanism for a custom resource
definition to indicate a destination for message delivery.
Addressable is the schema for the destination information. This is
typically stored in the object's status, as this information may
be generated by the controller.

Release Note

Added SinkCACerts to source status

Docs

[knative-prow]

@Rahul-Kumar-prog: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow]

Welcome @Rahul-Kumar-prog! It looks like this is your first PR to knative/pkg 🎉

[knative-prow]

Hi @Rahul-Kumar-prog. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Rahul-Kumar-prog]

@pierDipi I added this PR body through docs have a look and let me know because currently I don't know how to write a perfect PR body so I am sorry. let me know if anything I can do to improve myself.

[vishal-chdhry]

Thanks for the PR @Rahul-Kumar-prog!
Can you please set the "Fixes" in pr description to #2732, It will be helpful in tracking the progress of the issue

Also, it would be great if you would simplify the description to something like

Fixes #2732
Added `SinkCACerts` to source status

## Proposed Changes

<!-- Please categorize your changes:
- :gift: Add new feature
- :bug: Fix bug
- :broom: Update or clean up current behavior
- :wastebasket: Remove feature or internal logic
-->

- :gift: Add new feature
- Added support for storing the CA certs of the resolved sink's destination

/kind feature

Also, you may add this to the release note

Added SinkCACerts to source status

[Rahul-Kumar-prog]

Thankyou @vishal-chdhry for suggesting these corrections.

[pierDipi]

/ok-to-test

[pierDipi]

Thanks @Rahul-Kumar-prog

[pierDipi]

@Rahul-Kumar-prog you need to run hack/update-codegen.sh

[Rahul-Kumar-prog]

@pierDipi I have to run this here ?

[pierDipi]

on your local computer

[Rahul-Kumar-prog]

@pierDipi after that what should I need to do ?
should I have to add and commit this changes.

[vishal-chdhry]

once you run hack/update-codegen.sh file, it will generate some code, push it to this repository

[Rahul-Kumar-prog]

@vishal-chdhry this hack/update-codegen.sh, what this command actually do?

[vishal-chdhry]

@Rahul-Kumar-prog hack/update-codegen.sh is a script which

1. Updates auto-generated client libraries.
2. Creates API reference docs
3. Create deepcopy files
4. Generates checksums etc.

You should run it everytime you change a type definition

[Rahul-Kumar-prog]

@vishal-chdhry is there any resources to understand.

[vishal-chdhry]

@Rahul-Kumar-prog Yes! you can look into the file here: https://github.com/knative/pkg/blob/main/hack/update-codegen.sh
Also, read the developer's guide here: https://github.com/knative/pkg/blob/main/DEVELOPMENT.md

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (300df43) 81.53% compared to head (4594844) 81.50%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2733      +/-   ##
==========================================
- Coverage   81.53%   81.50%   -0.03%     
==========================================
  Files         163      163              
  Lines       10018    10018              
==========================================
- Hits         8168     8165       -3     
- Misses       1606     1608       +2     
- Partials      244      245       +1     

Impacted Files	Coverage Δ
apis/duck/v1/source_types.go	48.64% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[pierDipi]

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, Rahul-Kumar-prog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• apis/duck/OWNERS [pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pierDipi]

Thanks @Rahul-Kumar-prog