-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace all usages of deprecated wait.PollImmediate with wait.PollUntilContextTimeout #3004
Replace all usages of deprecated wait.PollImmediate with wait.PollUntilContextTimeout #3004
Conversation
…ilContextTimeout Signed-off-by: Prashant Rewar <108176843+prashantrewar@users.noreply.github.com>
@prashantrewar: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @prashantrewar! It looks like this is your first PR to knative/pkg 🎉 |
Hi @prashantrewar. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3004 +/- ##
=======================================
Coverage 78.68% 78.68%
=======================================
Files 188 188
Lines 11051 11051
=======================================
Hits 8695 8695
Misses 2092 2092
Partials 264 264 ☔ View full report in Codecov by Sentry. |
/retest |
/lgtm thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, prashantrewar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
/kind
Fixes #
Release Note
Docs