Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all usages of deprecated wait.PollImmediate with wait.PollUntilContextTimeout #3004

Merged

Conversation

prashantrewar
Copy link
Contributor

Changes

  • Replace usages of deprecated wait.PollImmediate with wait.PollUntilContextTimeout

/kind

Fixes #

Release Note

NONE

Docs


…ilContextTimeout

Signed-off-by: Prashant Rewar <108176843+prashantrewar@users.noreply.github.com>
Copy link

knative-prow bot commented Apr 1, 2024

@prashantrewar: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • Replace usages of deprecated wait.PollImmediate with wait.PollUntilContextTimeout

/kind

Fixes #

Release Note

NONE

Docs


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

knative-prow bot commented Apr 1, 2024

Welcome @prashantrewar! It looks like this is your first PR to knative/pkg 🎉

@knative-prow knative-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 1, 2024
Copy link

knative-prow bot commented Apr 1, 2024

Hi @prashantrewar. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso
Copy link
Member

dprotaso commented Apr 1, 2024

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 1, 2024
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 78.68%. Comparing base (5fe2303) to head (6fa93b1).
Report is 3 commits behind head on main.

Files Patch % Lines
test/kube_checks.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3004   +/-   ##
=======================================
  Coverage   78.68%   78.68%           
=======================================
  Files         188      188           
  Lines       11051    11051           
=======================================
  Hits         8695     8695           
  Misses       2092     2092           
  Partials      264      264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member

dprotaso commented Apr 2, 2024

/retest

@dprotaso
Copy link
Member

dprotaso commented Apr 2, 2024

/lgtm
/approve

thanks!

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2024
Copy link

knative-prow bot commented Apr 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, prashantrewar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2024
@knative-prow knative-prow bot merged commit fef5da9 into knative:main Apr 2, 2024
40 checks passed
@prashantrewar prashantrewar deleted the replace-wait.PollImmeddiate branch April 2, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants