-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow skipping conversion crd update #3006
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Why not just delete the conversion webhook controller from your binary? Using a context options would require re-compilation anyways |
We keep this aligned with the knative/operator https://github.com/knative/operator/blob/main/config/crd/bases/operator.knative.dev_knativeservings.yaml#L2470 |
@dprotaso wdyth about my last comment? |
I guess I'm still confused are you looking to skip conversion webhook callbacks or skip the reconciliation that updates the cacert and service path? If it's the CA cert then don't we have the knobs(options) to change the default secret and properties?
I don't think you need to set that - it will default to what the API server supports - which is probably |
I'm going to close this out - i think downstream it just makes sense to drop the certificate reconciler from the webhook controller |
Changes
/kind enhancement