-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop mako #3060
drop mako #3060
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3060 +/- ##
==========================================
- Coverage 78.59% 78.43% -0.17%
==========================================
Files 191 191
Lines 8934 8934
==========================================
- Hits 7022 7007 -15
- Misses 1643 1665 +22
+ Partials 269 262 -7 ☔ View full report in Codecov by Sentry. |
/retest |
Downstream failures are expected until eventing merges their PR /assign @pierDipi |
/retest |
I'm going to revert the linter changes in this PR and pull it into a separate one |
/override "style / Golang / Lint" |
@dprotaso: Overrode contexts on behalf of dprotaso: style / Golang / Lint In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
Fixes: #2820