Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging operator contract abstraction #906

Closed
mdemirhan opened this issue May 17, 2018 · 8 comments
Closed

Logging operator contract abstraction #906

mdemirhan opened this issue May 17, 2018 · 8 comments
Assignees
Labels
area/monitoring kind/spec Discussion of how a feature should be exposed to customers. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@mdemirhan
Copy link
Contributor

We are currently exposing fluentd config as part of our operator contracts to allow plugging in different logging backends. This is approach will make it harder for us to move to a different collection agent in the future - changing agents will not be seamless and will require cluster operators to take action.

We should re-evaluate this decision before the product is v1. The other option is:

  • Create a config of our own as part of operator contracts and let the operator edit our config. Our system needs to generate the appropriate fluentd config (or whatever agent we are using) based on this
  • Define a "plugin author" contract and allow contributors to add support for more backends
@loganlee
Copy link

loganlee commented May 18, 2018 via email

@evankanderson
Copy link
Member

/kind spec

I see two PRs were merged, is this done?

@google-prow-robot google-prow-robot added the kind/spec Discussion of how a feature should be exposed to customers. label Jun 22, 2018
@evankanderson
Copy link
Member

/assign mdemirhan
/assign loganlee

@yanweiguo
Copy link
Contributor

The tow merged PRs are relative. This is not done yet.

@mdemirhan mdemirhan added this to the Ice Box milestone Nov 28, 2018
@mdemirhan mdemirhan removed their assignment Jun 11, 2019
@knative-housekeeping-robot

Issues go stale after 90 days of inactivity.
Mark the issue as fresh by adding the comment /remove-lifecycle stale.
Stale issues rot after an additional 30 days of inactivity and eventually close.
If this issue is safe to close now please do so by adding the comment /close.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/lifecycle stale

@knative-prow-robot knative-prow-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 22, 2019
@knative-housekeeping-robot

Stale issues rot after 30 days of inactivity.
Mark the issue as fresh by adding the comment /remove-lifecycle rotten.
Rotten issues close after an additional 30 days of inactivity.
If this issue is safe to close now please do so by adding the comment /close.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/lifecycle rotten

@knative-prow-robot knative-prow-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 22, 2020
@knative-housekeeping-robot

Rotten issues close after 30 days of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh by adding the comment /remove-lifecycle rotten.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/close

@knative-prow-robot
Copy link
Contributor

@knative-housekeeping-robot: Closing this issue.

In response to this:

Rotten issues close after 30 days of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh by adding the comment /remove-lifecycle rotten.

Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso dprotaso removed this from the Ice Box milestone Oct 6, 2021
skonto added a commit to skonto/serving that referenced this issue Oct 14, 2024
Co-authored-by: Stavros Kontopoulos <st.kontopoulos@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitoring kind/spec Discussion of how a feature should be exposed to customers. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

8 participants