-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logging operator contract abstraction #906
Comments
I support this idea. I believe that even if fluentd is a dominant pattern,
this is an appropriate abstraction point to allow alternatives.
…On Thu, May 17, 2018 at 11:46 AM Mustafa Demirhan ***@***.***> wrote:
We are currently exposing fluentd config as part of our operator contracts
to allow plugging in different logging backends. This is approach will make
it harder for us to move to a different collection agent in the future -
changing agents will not be seamless and will require cluster operators to
take action.
We should re-evaluate this decision before the product is v1. The other
option is:
- Create a config of our own as part of operator contracts and let the
operator edit our config. Our system needs to generate the appropriate
fluentd config (or whatever agent we are using) based on this
- Define a "plugin author" contract and allow contributors to add
support for more backends
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#906>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACTWN7vXkm08-TUe0jipIRN3AQ1dyc0Cks5tzcVmgaJpZM4UDlTE>
.
--
*Logan Lee | Senior **Director, Product Management*
lolee@pivotal.io *|* *+1-415-713-9894 **|* *pivotal.io
<http://www.pivotal.io/>*
|
/kind spec I see two PRs were merged, is this done? |
/assign mdemirhan |
The tow merged PRs are relative. This is not done yet. |
Issues go stale after 90 days of inactivity. Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra. /lifecycle stale |
Stale issues rot after 30 days of inactivity. Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra. /lifecycle rotten |
Rotten issues close after 30 days of inactivity. Send feedback to Knative Productivity Slack channel or file an issue in knative/test-infra. /close |
@knative-housekeeping-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Co-authored-by: Stavros Kontopoulos <st.kontopoulos@gmail.com>
We are currently exposing fluentd config as part of our operator contracts to allow plugging in different logging backends. This is approach will make it harder for us to move to a different collection agent in the future - changing agents will not be seamless and will require cluster operators to take action.
We should re-evaluate this decision before the product is v1. The other option is:
The text was updated successfully, but these errors were encountered: