Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] test metadata fix #11896

Closed
wants to merge 2 commits into from
Closed

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Sep 1, 2021

Testing with: knative/pkg#2249

Which fixes #11448

@knative-prow-robot knative-prow-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 1, 2021
@google-cla google-cla bot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 1, 2021
@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 1, 2021
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2021
@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #11896 (5a3b9ad) into main (24c59e0) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11896      +/-   ##
==========================================
- Coverage   87.76%   87.73%   -0.04%     
==========================================
  Files         196      196              
  Lines        9430     9430              
==========================================
- Hits         8276     8273       -3     
- Misses        894      895       +1     
- Partials      260      262       +2     
Impacted Files Coverage Δ
pkg/reconciler/configuration/configuration.go 84.61% <0.00%> (-2.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24c59e0...5a3b9ad. Read the comment docs.

@dprotaso
Copy link
Member Author

dprotaso commented Sep 1, 2021

Closing looks like everything passes

@dprotaso dprotaso closed this Sep 1, 2021
@dprotaso dprotaso deleted the test-unknown-metadata branch February 1, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mutation failed: cannot decode incoming new object: json: unknown field "subresource"
2 participants