13690: add startupProbe schema change.

[amarflybot]

Add Support for startupProbe in Knative

[linux-foundation-easycla]

• ❌ The commit (91fcc6c, 1f37731). This user is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

[knative-prow]

Hi @amarflybot. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amarflybot
Once this PR has been reviewed and has the lgtm label, please assign zroubalik for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS
• pkg/apis/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[psschwei]

Thanks for the PR!

Adding startup probes is a bit more complex than just allowing users to set a startup probe. For example, both the QP and the activator run (different) checks on the user container readiness, but those checks shouldn't run until after the startup probe finishes.

See the discussion in #10037 for more of what's needed.

/hold

[dprotaso]

Closing this out - let's continue the discussion on - #10037

tl;dr - we don't want to just blindly accepted startupProbes as they interfere with our queueProxy probing. Thus this needs a proper design