Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup net-certmanager integration #15168

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

ReToCode
Copy link
Member

Context

Proposed Changes

  • Follow-up for Integrate net-certmanager in Serving #15066
  • Removes specific logging configuration (should be covered by serving controller now)
  • Moved config file to ytt instead of third_party (as there is no longer a third_party repo here)
  • Removed istio config for webhook that is now part of serving webhook

I did not find more things we might need to update.

/assign @skonto

@knative-prow knative-prow bot requested review from izabelacg and skonto April 29, 2024 08:46
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 29, 2024
Copy link

knative-prow bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.79%. Comparing base (c2d0af1) to head (d46df3e).
Report is 74 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15168      +/-   ##
==========================================
+ Coverage   84.11%   84.79%   +0.67%     
==========================================
  Files         213      218       +5     
  Lines       16783    13469    -3314     
==========================================
- Hits        14117    11421    -2696     
+ Misses       2315     1682     -633     
- Partials      351      366      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/e2e-common.sh Outdated Show resolved Hide resolved
@skonto
Copy link
Contributor

skonto commented Apr 29, 2024

Should we start the process for deprecating net-certmanager?

@ReToCode
Copy link
Member Author

Should we start the process for deprecating net-certmanager?

Yes: knative/community#1563, I think I have most. Anything else needed? As per 1.15, we do not need to release it any longer. Docs should be covered in: knative/docs#5804

@skonto
Copy link
Contributor

skonto commented Apr 29, 2024

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
@knative-prow knative-prow bot merged commit 08e8c32 into knative:main Apr 29, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants