-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup net-certmanager integration #15168
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ReToCode The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15168 +/- ##
==========================================
+ Coverage 84.11% 84.79% +0.67%
==========================================
Files 213 218 +5
Lines 16783 13469 -3314
==========================================
- Hits 14117 11421 -2696
+ Misses 2315 1682 -633
- Partials 351 366 +15 ☔ View full report in Codecov by Sentry. |
Should we start the process for deprecating net-certmanager? |
Yes: knative/community#1563, I think I have most. Anything else needed? As per 1.15, we do not need to release it any longer. Docs should be covered in: knative/docs#5804 |
/lgtm |
Context
Proposed Changes
third_party
(as there is no longer a third_party repo here)I did not find more things we might need to update.
/assign @skonto