[WIP][TEST-ONLY] Test lease holder with empty string

[skonto]

Fixes #

Proposed Changes

• Test only
• See TestControllerHA is flakey #15238 (comment)

Release Note

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [skonto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[skonto]

/test ?

[knative-prow]

@skonto: The following commands are available to trigger required jobs:

• /test build-tests
• /test contour-latest
• /test contour-tls
• /test gateway-api-latest
• /test istio-latest-no-mesh
• /test istio-latest-no-mesh-tls
• /test kourier-stable
• /test kourier-stable-tls
• /test unit-tests
• /test upgrade-tests

The following commands are available to trigger optional jobs:

• /test gateway-api-latest-and-contour
• /test https
• /test istio-latest-mesh
• /test istio-latest-mesh-short
• /test istio-latest-mesh-tls
• /test performance-tests

Use /test all to run the following jobs that were automatically triggered:

• build-tests_serving_main
• istio-latest-no-mesh-tls_serving_main
• istio-latest-no-mesh_serving_main
• unit-tests_serving_main
• upgrade-tests_serving_main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.78%. Comparing base (79da324) to head (64f7823).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #15251      +/-   ##
==========================================
+ Coverage   84.76%   84.78%   +0.01%     
==========================================
  Files         218      218              
  Lines       13479    13479              
==========================================
+ Hits        11426    11428       +2     
+ Misses       1686     1685       -1     
+ Partials      367      366       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[knative-prow]

@skonto: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
build-tests_serving_main	64f7823	link	true	/test build-tests

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[skonto]

Copying from test logs:

{"Time":"2024-05-27T11:38:23.270186536Z","Action":"output","Package":"knative.dev/serving/test/ha","Test":"TestControllerHA","Output":"    ha.go:61: GetLeaders[controller] skipping lease controller.knative.dev.serving.pkg.reconciler.certificate.reconciler.00-of-10 as it has no holder\n"}
{"Time":"2024-05-27T11:38:23.270226986Z","Action":"output","Package":"knative.dev/serving/test/ha","Test":"TestControllerHA","Output":"    ha.go:61: GetLeaders[controller] skipping lease controller.knative.dev.serving.pkg.reconciler.certificate.reconciler.01-of-10 as it has no holder\n"}
{"Time":"2024-05-27T11:38:23.270235576Z","Action":"output","Package":"knative.dev/serving/test/ha","Test":"TestControllerHA","Output":"    ha.go:61: GetLeaders[controller] skipping lease controller.knative.dev.serving.pkg.reconciler.certificate.reconciler.02-of-10 as it has no holder\n"}
{"Time":"2024-05-27T11:38:23.270240116Z","Action":"output","Package":"knative.dev/serving/test/ha","Test":"TestControllerHA","Output":"    ha.go:61: GetLeaders[controller] skipping lease controller.knative.dev.serving.pkg.reconciler.certificate.reconciler.03-of-10 as it has no holder\n"}
{"Time":"2024-05-27T11:38:23.270244566Z","Action":"output","Package":"knative.dev/serving/test/ha","Test":"TestControllerHA","Output":"    ha.go:61: GetLeaders[controller] skipping lease controller.knative.dev.serving.pkg.reconciler.certificate.reconciler.04-of-10 as it has no holder\n"}
{"Time":"2024-05-27T11:38:23.270254686Z","Action":"output","Package":"knative.dev/serving/test/ha","Test":"TestControllerHA","Output":"    ha.go:61: GetLeaders[controller] skipping lease controller.knative.dev.serving.pkg.reconciler.certificate.reconciler.05-of-10 as it has no holder\n"}
{"Time":"2024-05-27T11:38:23.270327216Z","Action":"output","Package":"knative.dev/serving/test/ha","Test":"TestControllerHA","Output":"    ha.go:61: GetLeaders[controller] skipping lease controller.knative.dev.serving.pkg.reconciler.certificate.reconciler.06-of-10 as it has no holder\n"}
{"Time":"2024-05-27T11:38:23.270335006Z","Action":"output","Package":"knative.dev/serving/test/ha","Test":"TestControllerHA","Output":"    ha.go:61: GetLeaders[controller] skipping lease controller.knative.dev.serving.pkg.reconciler.certificate.reconciler.07-of-10 as it has no holder\n"}
{"Time":"2024-05-27T11:38:23.270361176Z","Action":"output","Package":"knative.dev/serving/test/ha","Test":"TestControllerHA","Output":"    ha.go:61: GetLeaders[controller] skipping lease controller.knative.dev.serving.pkg.reconciler.certificate.reconciler.08-of-10 as it has no holder\n"}
{"Time":"2024-05-27T11:38:23.270399136Z","Action":"output","Package":"knative.dev/serving/test/ha","Test":"TestControllerHA","Output":"    ha.go:61: GetLeaders[controller] skipping lease controller.knative.dev.serving.pkg.reconciler.certificate.reconciler.09-of-10 as it has no holder\n"}