Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed liveness periodseconds to 10 so that crashloopback off doe… #15256

Merged
merged 1 commit into from
May 27, 2024

Conversation

mukulgit123
Copy link
Contributor

@mukulgit123 mukulgit123 commented May 27, 2024

Fixes #15255

Proposed Changes

  • Increase periodseconds of livenessprobe to 10 as found in the issue

Release Note

Adjust liveness probe to account for stale leases - otherwise webhook would crashloop forever

…sn't happen which causesexpired lease to get stuck.
Copy link

linux-foundation-easycla bot commented May 27, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@knative-prow knative-prow bot requested review from izabelacg and ReToCode May 27, 2024 14:59
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 27, 2024
Copy link

knative-prow bot commented May 27, 2024

Welcome @mukulgit123! It looks like this is your first PR to knative/serving 🎉

Copy link

knative-prow bot commented May 27, 2024

Hi @mukulgit123. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 27, 2024
@dprotaso
Copy link
Member

/ok-to-test

@knative-prow knative-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 27, 2024
Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.73%. Comparing base (57874d7) to head (c2ec57b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15256      +/-   ##
==========================================
- Coverage   84.74%   84.73%   -0.02%     
==========================================
  Files         218      218              
  Lines       13479    13479              
==========================================
- Hits        11423    11421       -2     
- Misses       1688     1689       +1     
- Partials      368      369       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2024
Copy link

knative-prow bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, mukulgit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2024
@dprotaso
Copy link
Member

/cherry-pick release-1.14

@knative-prow-robot
Copy link
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso
Copy link
Member

/cherry-pick release-1.13

@knative-prow-robot
Copy link
Contributor

@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit 71d1654 into knative:main May 27, 2024
63 checks passed
@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #15257

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot
Copy link
Contributor

@dprotaso: new pull request created: #15258

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

knative-serving v1.10.6 webhook pods failing due to "server key missing" missing error
3 participants