Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable failng contour/gateway api tests #15334

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Jun 18, 2024

Contour has a new release out (1.29) which fixes this issue

Fixes: knative-extensions/net-gateway-api#711
Fixes: #15092
Fixes: #15089

@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 18, 2024
@knative-prow knative-prow bot requested review from ReToCode and skonto June 18, 2024 21:45
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.72%. Comparing base (e56319d) to head (2b1d95f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15334      +/-   ##
==========================================
- Coverage   84.80%   84.72%   -0.08%     
==========================================
  Files         218      218              
  Lines       13508    13508              
==========================================
- Hits        11455    11445      -10     
- Misses       1687     1692       +5     
- Partials      366      371       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dprotaso
Copy link
Member Author

/test ?

Copy link

knative-prow bot commented Jun 18, 2024

@dprotaso: The following commands are available to trigger required jobs:

  • /test build-tests
  • /test contour-latest
  • /test contour-tls
  • /test gateway-api-latest
  • /test istio-latest-no-mesh
  • /test istio-latest-no-mesh-tls
  • /test kourier-stable
  • /test kourier-stable-tls
  • /test unit-tests
  • /test upgrade-tests

The following commands are available to trigger optional jobs:

  • /test gateway-api-latest-and-contour
  • /test https
  • /test istio-latest-mesh
  • /test istio-latest-mesh-short
  • /test istio-latest-mesh-tls
  • /test performance-tests

Use /test all to run the following jobs that were automatically triggered:

  • build-tests_serving_main
  • istio-latest-no-mesh-tls_serving_main
  • istio-latest-no-mesh_serving_main
  • unit-tests_serving_main
  • upgrade-tests_serving_main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dprotaso
Copy link
Member Author

/test gateway-api-latest
/test gateway-api-latest-and-contour

@skonto
Copy link
Contributor

skonto commented Jun 19, 2024

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2024
Copy link

knative-prow bot commented Jun 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit c980773 into knative:main Jun 19, 2024
69 checks passed
@dprotaso dprotaso deleted the contour-gateway-api-tests branch June 19, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
2 participants