Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always install istio from HEAD for upgrade tests #3522

Merged
merged 3 commits into from
Mar 25, 2019
Merged

Always install istio from HEAD for upgrade tests #3522

merged 3 commits into from
Mar 25, 2019

Conversation

jonjohnsonjr
Copy link
Contributor

Fixes #3506

@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features labels Mar 25, 2019
@jonjohnsonjr jonjohnsonjr changed the title Always install istio from HEAD Always install istio from HEAD for upgrade tests Mar 25, 2019
@jonjohnsonjr
Copy link
Contributor Author

Seems to be installing serving from HEAD even for latest release:

I0325 18:31:57.151] ==================================================
I0325 18:31:57.152] ==== INSTALLING KNATIVE LATEST PUBLIC RELEASE ====
I0325 18:31:57.152] ==================================================
I0325 18:31:57.221] 2019/03/25 18:31:57 Building github.com/knative/serving/cmd/queue

...

I0325 18:34:24.048] Building Knative Serving
I0325 18:34:24.049] Building Monitoring & Logging
I0325 18:34:24.049] All manifests generated
I0325 18:34:24.049] Generated manifests:
I0325 18:34:24.049] ISTIO_CRD_YAML=/go/src/github.com/knative/serving/third_party/istio-1.0.6/istio-crds.yaml
I0325 18:34:24.050] ISTIO_LEAN_YAML=/go/src/github.com/knative/serving/third_party/istio-1.0.6/istio-lean.yaml
I0325 18:34:24.050] ISTIO_YAML=/go/src/github.com/knative/serving/third_party/istio-1.0.6/istio.yaml
I0325 18:34:24.050] MONITORING_LOG_ELASTICSEARCH_YAML=/tmp/tmp.PZ0daHQjVg/monitoring-logs-elasticsearch.yaml
I0325 18:34:24.050] MONITORING_METRIC_PROMETHEUS_YAML=/tmp/tmp.PZ0daHQjVg/monitoring-metrics-prometheus.yaml
I0325 18:34:24.050] MONITORING_TRACE_ZIPKIN_IN_MEM_YAML=/tmp/tmp.PZ0daHQjVg/monitoring-tracing-zipkin-in-mem.yaml
I0325 18:34:24.050] MONITORING_TRACE_ZIPKIN_YAML=/tmp/tmp.PZ0daHQjVg/monitoring-tracing-zipkin.yaml
I0325 18:34:24.051] MONITORING_YAML=/tmp/tmp.PZ0daHQjVg/monitoring.yaml
I0325 18:34:24.051] SERVING_YAML=/tmp/tmp.PZ0daHQjVg/serving.yaml
I0325 18:34:24.051] >> Installing Knative serving
I0325 18:34:24.051] Istio CRD YAML: /go/src/github.com/knative/serving/third_party/istio-1.0.6/istio-crds.yaml
I0325 18:34:24.051] Istio YAML: /go/src/github.com/knative/serving/third_party/istio-1.0.6/istio.yaml
I0325 18:34:24.051] Knative YAML: /tmp/tmp.PZ0daHQjVg/serving.yaml
I0325 18:34:24.052] Knative Build YAML: ./third_party/config/build/
I0325 18:34:24.052] Knative Build Pipeline YAML: ./third_party/config/pipeline/

Trying to just call install_knative_serving_standard directly to see if that's the issue.

@adrcunha adrcunha requested review from adrcunha and removed request for ericKlawitter and jessiezcc March 25, 2019 19:29
@adrcunha
Copy link
Contributor

Something's weird. Running locally I get the right behavior:

==================================================
==== INSTALLING KNATIVE LATEST PUBLIC RELEASE ====
==================================================
>> Installing Knative serving
Istio CRD YAML: https://github.com/knative/serving/releases/download/v0.4.0/istio-crds.yaml
Istio YAML: https://github.com/knative/serving/releases/download/v0.4.0/istio.yaml
Knative YAML: https://github.com/knative/serving/releases/download/v0.4.0/serving.yaml
Knative Build YAML: ./third_party/config/build/
Knative Build Pipeline YAML: ./third_party/config/pipeline/
>> Bringing up Istio
...

@jonjohnsonjr
Copy link
Contributor Author

Looks like I just needed to run build_knative_from_source first. Mea culpa.

@jonjohnsonjr
Copy link
Contributor Author

/retest

1 similar comment
@jonjohnsonjr
Copy link
Contributor Author

/retest

@jonjohnsonjr
Copy link
Contributor Author

/assign @adrcunha @mattmoor

adrcunha
adrcunha reviewed Mar 25, 2019
View reviewed changes
test/e2e-upgrade-tests.sh Outdated Show resolved Hide resolved
@adrcunha @jonjohnsonjr
Update test/e2e-upgrade-tests.sh
387c5f4 
Co-Authored-By: jonjohnsonjr <jonjohnson@google.com>
@adrcunha
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2019
@adrcunha
Copy link
Contributor

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrcunha, jonjohnsonjr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2019
@jonjohnsonjr
Copy link
Contributor Author

/retest

@knative-prow-robot knative-prow-robot merged commit 9328997 into knative:master Mar 25, 2019
@jonjohnsonjr jonjohnsonjr deleted the istio-head branch March 26, 2019 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrcunha adrcunha adrcunha left review comments

Assignees

@mattmoor mattmoor

@adrcunha adrcunha

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release It flags unit/e2e/conformance/perf test issues for product features lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonjohnsonjr @adrcunha @knative-prow-robot @mattmoor