Send request logs from activator. #3927
Conversation
knative-prow-robot
added
the
size/XL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdemirhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
|
I moved request_log.go from pkg/queue to pkg/http - I don't know why it doesn't show as renamed. The file has two additions to it: getTemplate and SetTemplate funcs. |
mdemirhan
requested review from
yanweiguo and
mattmoor
and removed request for
tcnghia
There was a problem hiding this comment.
@vagababov: 2 warnings.
In response to this:
/lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
@vagababov I tried doing that but for some reason, it keeps adding and removing, rather than moving. |
|
/lint |
There was a problem hiding this comment.
@mdemirhan: 0 warnings.
In response to this:
/lint
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
| // and effectively disable request logs. | ||
| if templateStr != "" { | ||
| // Make sure that the template ends with a newline. Otherwise, | ||
| // logging backends will not be able to parse entries separately. |
There was a problem hiding this comment.
Should we check this after applying the template? I bet it would be more reliable?
There was a problem hiding this comment.
No sure if I understand - if we check this after we apply, compiled template won't have the newline and will not work.
There was a problem hiding this comment.
I see, because it executes it directly to a writer...
|
Moves in git are heuristic based. If you make enough edits, it stops showing up that way. You'll also get strange "moves" when you add / remove similar enough files. |
# Conflicts: # cmd/activator/main.go
# Conflicts: # cmd/activator/main.go # cmd/queue/main.go
|
The following is the coverage report on pkg/.
|
|
/lgtm |
Fixes #3781
I moved request_log.go from pkg/queue to pkg/http - I don't know why it doesn't show as renamed. The file has two additions to it: getTemplate and SetTemplate funcs.