Reduce the idle timeouts in the default transports. #3996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps to deal with the problem we're seeing with the lean Istio, wherein the connection to the K8s service is not terminated when the underlying endpoint changes, since in the absence of the sidecar while the socket is alive, nothing disturbs the connection. This stops us from scaling to 0.
knative-prow-robot
added
size/XS
|
/cc @mattmoor @mdemirhan |
knative-prow-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattmoor, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps to deal with the problem we're seeing
with the lean Istio, wherein the connection to the K8s
service is not terminated when the underlying endpoint changes,
since in the absence of the sidecar while the socket is alive,
nothing disturbs the connection.
This stops us from scaling to 0.
Fixes #3987
A more comprehensive approach will be in #3986
Proposed Changes