Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 8022/health to 8012/8013 #5524

Merged
merged 20 commits into from Sep 20, 2019

Conversation

@yanweiguo
Copy link
Contributor

yanweiguo commented Sep 12, 2019

Part of #5465.

Proposed Changes

  • Change HealthState to return queue as body if probe succeeds and return 503 instead of 400 if probe fails.
  • Use HealthState to probe user-container in 8012/8013 just like 8022/health.
  • Add -port flag to ExecProbe command to tell which port to send request, 8012 or 8013.
  • Remove 8022/health and let ExecProbe send probe request to 8012/8013 with header K-Network-Probe=queue.
yanweiguo added 9 commits Sep 11, 2019
Copy link

knative-prow-robot left a comment

@yanweiguo: 0 warnings.

In response to this:

Part of #5465.

Proposed Changes

  • Change HealthState to return queue as body if probe succeeds and return 503 instead of 400 if probe fails.
  • Use HealthState to probe user-container in 8012/8013 just like 8022/health.
  • Add -port flag to ExecProbe command to tell which port to send request, 8012 or 8013.
  • Remove 8022/health and let ExecProbe send probe request to 8012/8013 with header K-Network-Probe=queue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

markusthoemmes left a comment

Not an entire review, I'm having somewhat of a hard time following the paths so I might need another look.

pkg/queue/health/health_state.go Outdated Show resolved Hide resolved
pkg/reconciler/revision/resources/queue.go Outdated Show resolved Hide resolved
cmd/queue/main.go Show resolved Hide resolved
cmd/queue/main.go Outdated Show resolved Hide resolved
cmd/queue/main.go Outdated Show resolved Hide resolved
pkg/queue/health/health_state_test.go Outdated Show resolved Hide resolved
pkg/queue/health/health_state.go Outdated Show resolved Hide resolved
yanweiguo added 3 commits Sep 13, 2019
@yanweiguo

This comment has been minimized.

Copy link
Contributor Author

yanweiguo commented Sep 16, 2019

/test pull-knative-serving-upgrade-tests

@yanweiguo

This comment has been minimized.

Copy link
Contributor Author

yanweiguo commented Sep 16, 2019

It's ready for another look.

Copy link
Contributor

vagababov left a comment

I have just nits.
In general looks good to me, but someone has to look as well.

/approve

pkg/queue/health/health_state.go Outdated Show resolved Hide resolved
cmd/queue/main_test.go Outdated Show resolved Hide resolved
@knative-prow-robot

This comment has been minimized.

Copy link

knative-prow-robot commented Sep 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vagababov, yanweiguo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

yanweiguo added 2 commits Sep 18, 2019
@yanweiguo

This comment has been minimized.

Copy link
Contributor Author

yanweiguo commented Sep 18, 2019

@markusthoemmes any more comments?

@yanweiguo

This comment has been minimized.

Copy link
Contributor Author

yanweiguo commented Sep 18, 2019

/test pull-knative-serving-unit-tests
/test pull-knative-serving-integration-tests

cmd/queue/main.go Outdated Show resolved Hide resolved
pkg/reconciler/revision/resources/queue.go Outdated Show resolved Hide resolved
cmd/queue/main.go Outdated Show resolved Hide resolved
cmd/queue/main.go Show resolved Hide resolved
yanweiguo added 2 commits Sep 19, 2019
@yanweiguo

This comment has been minimized.

Copy link
Contributor Author

yanweiguo commented Sep 19, 2019

/test pull-knative-serving-unit-tests

@knative-test-reporter-robot

This comment has been minimized.

Copy link

knative-test-reporter-robot commented Sep 19, 2019

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-unit-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-unit-tests:

pkg/activator/net.TestRevisionWatcher
pkg/activator/net.TestRevisionWatcher/podIP_slow_ready_then_clusterIP
yanweiguo added 4 commits Sep 20, 2019
@yanweiguo

This comment has been minimized.

Copy link
Contributor Author

yanweiguo commented Sep 20, 2019

/test pull-knative-serving-unit-tests

1 similar comment
@yanweiguo

This comment has been minimized.

Copy link
Contributor Author

yanweiguo commented Sep 20, 2019

/test pull-knative-serving-unit-tests

@tcnghia

This comment has been minimized.

Copy link
Contributor

tcnghia commented Sep 20, 2019

/lgtm

@knative-prow-robot knative-prow-robot merged commit c71820d into knative:master Sep 20, 2019
8 checks passed
8 checks passed
cla/google All necessary CLAs are signed
pull-knative-serving-build-tests Job succeeded.
Details
pull-knative-serving-go-coverage Job succeeded.
Details
pull-knative-serving-integration-tests Job succeeded.
Details
pull-knative-serving-smoke-tests Job succeeded.
Details
pull-knative-serving-unit-tests Job succeeded.
Details
pull-knative-serving-upgrade-tests Job succeeded.
Details
tide In merge pool.
Details
@yanweiguo yanweiguo deleted the yanweiguo:move_health_path branch Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.