-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change transport of direct client for customized MaxIdleConns #8568
Conversation
Signed-off-by: Lance Liu <xuliuxl@cn.ibm.com>
Welcome @lanceliuu! It looks like this is your first PR to knative/serving 🎉 |
Hi @lanceliuu. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test /hold |
Signed-off-by: Lance Liu <xuliuxl@cn.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/unhold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lanceliuu, markusthoemmes, vagababov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Currently we noticed the CPU usage for autoscaler is high when there are hundreds of pods running in cluster. From the CPU profling we can tell that it is spending on dialing for connections.
The optimization in #8367 of @julz works but the default value 100 of
MaxIdleConns
is too small for pod scraping. The customized transport config from pkg/network with 1000 ofMaxIdleConns
should works better. After applying this change I see a significant CPU drop ( 54% -> 36%) with 300 pods running in cluster.Release Note