Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize positive pod count a bit #8759

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Optimize positive pod count a bit #8759

merged 1 commit into from
Jul 22, 2020

Conversation

vagababov
Copy link
Contributor

🤦 should've done the first time right!

  • there's only one ready status, so for pods which are not ready we'd do more iterations
    even though we know not to count this pod already

/assign @yanweiguo

@vagababov
optimize positive pod count a bit
a05f922 
- there's only one ready status, so for pods which are not ready we'd do more iterations
  even though we know not to count this pod already
@knative-prow-robot knative-prow-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/API API objects and controllers labels Jul 22, 2020
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 22, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2020
@knative-metrics-robot
Copy link

The following is the coverage report on the affected files.
Say /test pull-knative-serving-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/resources/pods.go 92.7% 92.9% 0.1

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2020
@knative-test-reporter-robot
Copy link

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-integration-tests 2020-07-22 19:23:44.552 +0000 UTC 1/3

Automatically retrying due to test flakiness...
/test pull-knative-serving-integration-tests

@vagababov
Copy link
Contributor Author

/retest

@knative-prow-robot knative-prow-robot merged commit 99b3796 into knative:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whaught whaught whaught left review comments

@dprotaso dprotaso Awaiting requested review from dprotaso

Assignees

@yanweiguo yanweiguo

@whaught whaught

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@vagababov @knative-prow-robot @knative-metrics-robot @knative-test-reporter-robot @whaught @googlebot @yanweiguo