Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate labels and annotations from Route to placeholder service #8798

Merged
merged 1 commit into from
Jul 24, 2020

Conversation

nak3
Copy link
Contributor

@nak3 nak3 commented Jul 24, 2020

This patch changes to propagate placeholder service's labels and
annotations from Route.

Currently there are no way to add annotation and labels to the
placeholder service except for manual.

/lint

Release Note

Placeholder service's labels and annotations are propagated from Route.

This patch changes to propagate placeholder service's labels and
annotations from Route.

Currently there are no way to add annotation and labels to the
placeholder service except for manual.
@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jul 24, 2020
@knative-prow-robot knative-prow-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 24, 2020
@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2020
Copy link
Contributor

@knative-prow-robot knative-prow-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nak3: 0 warnings.

In response to this:

This patch changes to propagate placeholder service's labels and
annotations from Route.

Currently there are no way to add annotation and labels to the
placeholder service except for manual.

/lint

Release Note

Placeholder service's labels and annotations are propagated from Route.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot added area/API API objects and controllers area/networking labels Jul 24, 2020
@nak3
Copy link
Contributor Author

nak3 commented Jul 24, 2020

This is based on user's request: https://knative.slack.com/archives/CA9RHBGJX/p1595390943143500

And one note:
I didn't change it to reconcile the placeholder service aggressively.
It means that even if we updated the label to the route, the placeholder service is not reconciled automatically. It is the same behavior with current KIngress.

@vagababov
Copy link
Contributor

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2020
@yanweiguo
Copy link
Contributor

/lgtm

@knative-test-reporter-robot

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-integration-tests 2020-07-24 19:00:44.355 +0000 UTC 1/3

Automatically retrying due to test flakiness...
/test pull-knative-serving-integration-tests

@knative-prow-robot knative-prow-robot merged commit 1517b17 into knative:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/API API objects and controllers area/networking cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants