-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate labels and annotations from Route to placeholder service #8798
Conversation
This patch changes to propagate placeholder service's labels and annotations from Route. Currently there are no way to add annotation and labels to the placeholder service except for manual.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nak3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nak3: 0 warnings.
In response to this:
This patch changes to propagate placeholder service's labels and
annotations from Route.Currently there are no way to add annotation and labels to the
placeholder service except for manual./lint
Release Note
Placeholder service's labels and annotations are propagated from Route.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
This is based on user's request: https://knative.slack.com/archives/CA9RHBGJX/p1595390943143500 And one note: |
/lgtm |
/lgtm |
The following jobs failed:
Automatically retrying due to test flakiness... |
This patch changes to propagate placeholder service's labels and
annotations from Route.
Currently there are no way to add annotation and labels to the
placeholder service except for manual.
/lint
Release Note