Allow configuring activator max idle connections #9027
Conversation
Inject the transport into activatorHandler and allow configuring its default maxIdleConns using a flag. As a bonus, this means the tests for activatorHandler no longer need to do casts and set the private transport field. Using a flag rather than a configmap here because maxIdleConns can't be easily changed dynamically so we really need the value on startup.
knative-prow-robot
added
the
size/M
There was a problem hiding this comment.
@julz: 0 warnings.
In response to this:
Inject the transport into activatorHandler and allow configuring maxIdleConns using a flag. As a bonus, this means the tests for activatorHandler no longer need to do casts and set the private transport field \o/.
Using a flag rather than a configmap here because maxIdleConns can't be easily changed dynamically, so we really need the value on startup.
/assign @markusthoemmes @vagababov
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
|
(looks like cmd/activator isn't owned by same owners as pkg/activator, seems wrong! Opened #9028). |
knative-prow-robot
added
the
approved
|
/retest |
cmd/activator/main.go
Outdated
| @@ -195,9 +199,11 @@ func main() { | |||
| concurrencyReporter := activatorhandler.NewConcurrencyReporter(ctx, env.PodName, statCh) | |||
| go concurrencyReporter.Run(ctx.Done()) | |||
|
|
|||
| proxyTransport := pkgnet.NewAutoTransport(*maxIdleProxyConns, 100 /*maxidleperhost*/) | |||
There was a problem hiding this comment.
Do we want to tweak maxidleperhost as well?
There was a problem hiding this comment.
actually, probably, Ill add
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: julz, markusthoemmes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
yeah, I can make it an env var, that way we don't have to worry about backwards compat if we remove the flag / move it a CM later I guess /hold |
knative-prow-robot
added
the
do-not-merge/hold
|
/unhold @vagababov take another look? |
knative-prow-robot
removed
the
do-not-merge/hold
|
The following is the coverage report on the affected files.
|
|
The following jobs failed:
Automatically retrying due to test flakiness... |
Inject the transport into activatorHandler and allow configuring maxIdleConns using a flag. As a bonus, this means the tests for activatorHandler no longer need to do casts and set the private transport field \o/.
Using a flag rather than a configmap here because maxIdleConns can't be easily changed dynamically, so we really need the value on startup.
/assign @markusthoemmes @vagababov