Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the GKE auth plugin in order to avoid spammy test output #3609

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Nov 8, 2022

@knative-prow knative-prow bot added area/tools Issues or PRs related to internal tools found at /tools approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 8, 2022
@dprotaso
Copy link
Member Author

dprotaso commented Nov 8, 2022

example output

Screen Shot 2022-11-08 at 2 01 49 PM

Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Interesting

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2022
@knative-prow
Copy link

knative-prow bot commented Nov 8, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 3b5fcbe into knative:main Nov 8, 2022
@dprotaso dprotaso deleted the use-auth-plugin branch November 9, 2022 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/tools Issues or PRs related to internal tools found at /tools lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants