Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup net-gateway-api/contour prow jobs #3612

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

dprotaso
Copy link
Member

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2022
@dprotaso
Copy link
Member Author

/assign @upodroid

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 10, 2022
@dprotaso
Copy link
Member Author

Once the job is merged I'll PR the e2e script changes

Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2022
@knative-prow
Copy link

knative-prow bot commented Nov 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 5e960e3 into knative:main Nov 10, 2022
@knative-prow
Copy link

knative-prow bot commented Nov 10, 2022

@dprotaso: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key net-gateway-api-main.gen.yaml using file prow/jobs/generated/knative-sandbox/net-gateway-api-main.gen.yaml

In response to this:

Part of knative-extensions/net-gateway-api#309

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso dprotaso deleted the gateway-contour branch November 10, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants