Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update serving channel name #3630

Merged
merged 1 commit into from
Dec 1, 2022
Merged

update serving channel name #3630

merged 1 commit into from
Dec 1, 2022

Conversation

dprotaso
Copy link
Member

@dprotaso dprotaso commented Dec 1, 2022

/assign @upodroid

@knative-prow
Copy link

knative-prow bot commented Dec 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added area/tools Issues or PRs related to internal tools found at /tools approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 1, 2022
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 1, 2022
@krsna-m
Copy link
Contributor

krsna-m commented Dec 1, 2022

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2022
@knative-prow knative-prow bot merged commit d2ab908 into knative:main Dec 1, 2022
@dprotaso dprotaso deleted the update-serving-channel-name branch December 1, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krsna-m krsna-m Awaiting requested review from krsna-m

@mgencur mgencur Awaiting requested review from mgencur

Assignees

@upodroid upodroid

@krsna-m krsna-m

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/tools Issues or PRs related to internal tools found at /tools lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dprotaso @krsna-m @upodroid