Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update PR template #3641

Merged
merged 1 commit into from
Dec 7, 2022
Merged

update PR template #3641

merged 1 commit into from
Dec 7, 2022

Conversation

krsna-m
Copy link
Contributor

@krsna-m krsna-m commented Dec 7, 2022

What this PR does, why we need it:

Format the pr template to be more clear.
Remove the # after the Fixes line so when one pastes a link a double ## does not occur thus not closing the issue.

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2022
@knative-prow knative-prow bot requested review from coryrc and mgencur December 7, 2022 16:11
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 7, 2022
@krsna-m
Copy link
Contributor Author

krsna-m commented Dec 7, 2022

/cc @dprotaso @cardil

@dprotaso
Copy link
Member

dprotaso commented Dec 7, 2022

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2022
@knative-prow knative-prow bot merged commit e00eaf0 into knative:main Dec 7, 2022
@knative-prow
Copy link

knative-prow bot commented Dec 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, kvmware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants