Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for obsolete releases #3647

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Check for obsolete releases #3647

merged 1 commit into from
Dec 19, 2022

Conversation

krsna-m
Copy link
Contributor

@krsna-m krsna-m commented Dec 12, 2022

Which issue(s) this PR fixes:

Fixes #3638

On #3643 where the max branches was reduced the older release branches were not cleaned up because there was not a new release being released at the same time.

This was a limitation in the release syncer tool which skipped if no release was being added. These changes allows one to run the tool at anytime to cleanup old releases regardless if there is a new release added or not.

@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/tools Issues or PRs related to internal tools found at /tools labels Dec 12, 2022
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2022
@krsna-m krsna-m requested a review from cardil December 12, 2022 17:01
Copy link
Contributor

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only some nit, as I had hard time understanding the changes.

tools/release-jobs-syncer/pkg/release.go Outdated Show resolved Hide resolved
Copy link
Contributor

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2022
@knative-prow
Copy link

knative-prow bot commented Dec 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cardil, kvmware

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@krsna-m
Copy link
Contributor Author

krsna-m commented Dec 19, 2022

/retest

@knative-prow knative-prow bot merged commit 0ce6c16 into knative:main Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/tools Issues or PRs related to internal tools found at /tools lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop infrastructure support for 1.5 jobs
2 participants