Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Rekt tests required in eventing #3679

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Make Rekt tests required in eventing #3679

merged 2 commits into from
Jan 25, 2023

Conversation

pierDipi
Copy link
Member

As per title

@pierDipi
Make rekt tests required
b8d4a4a 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Update codegen
003019c 
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@knative-prow knative-prow bot requested review from coryrc and mgencur January 25, 2023 14:19
@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 25, 2023
@pierDipi
Copy link
Member Author

/cc @cardil @upodroid

upodroid
upodroid approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@upodroid upodroid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2023
@knative-prow
Copy link

knative-prow bot commented Jan 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pierDipi, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2023
@knative-prow knative-prow bot merged commit ddc0994 into knative:main Jan 25, 2023
@knative-prow
Copy link

knative-prow bot commented Jan 25, 2023

@pierDipi: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key eventing-main.gen.yaml using file prow/jobs/generated/knative/eventing-main.gen.yaml

In response to this:

As per title

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upodroid upodroid upodroid approved these changes

@coryrc coryrc Awaiting requested review from coryrc

@mgencur mgencur Awaiting requested review from mgencur

@cardil cardil Awaiting requested review from cardil

Assignees

@upodroid upodroid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierDipi @upodroid