-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ESLint + Airbnb rules #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for the PR @Bryze, can you make the said changes?
.eslintrc.js
Outdated
"env": { | ||
"browser": true, | ||
"es6": true | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you have to add the following as well:
- react
- node
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think react
is recognized as a plugin rather than an env variable. throws me an error when I try to add react: true
to the env
block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This pr addresses #10
Have introduced two variants of the script
npm run test:lint
=> to run eslint over the whole projectnpm run test:lint-file <path-to-file>
=> to run eslint on a single file