Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stream as iterator part #454

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Conversation

bertho-zero
Copy link
Contributor

It would be useful to document this way of consuming streams.

@yagop
Copy link

yagop commented Jan 10, 2023

Bumping this

@OlivierCavadenti OlivierCavadenti merged commit 7702d42 into knex:main Jul 18, 2023
@bertho-zero
Copy link
Contributor Author

@OlivierCavadenti The comment, which is copied from the node doc, is not true with Knex, the basic functioning of the stream is altered.

If I break in the loop without destroy then the knex connection stays open.

The following destroy should be called automatically on a break:
https://github.com/knex/knex/blob/7c819d325cce1e4c364d0639e1228955d3b662db/test/integration2/query/misc/additional.spec.js#L160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants