fix: precision lost with bigint in sqlite3

[KlausBai]

add supportBigNumbers, bigNumberStrings options like mysql to support sqlite can read bigint by string

[coveralls]

Coverage: 92.392%. Remained the same when pulling cb1c067 on KlausBai:master into 0d27bcb on knex:master.

[KlausBai]

In my case, i had a table named 'addresses' with schema like this

with data

When i try to get this row by below code , I find that the precision of 'test' is just lost.

const knex = require('../knex')

const instance = knex({
    client: 'better-sqlite3',
    connection: {
      filename: './data.db',
    },
    useNullAsDefault: true
  })

const conn = instance('addresses');

conn.select('*')
conn.first();
conn.where('id',1);
conn.then(res=>console.log({res}))

so I try to add supportBigNumbers, bigNumberStrings options to support knex return bigint value by 'string' , like knex's mysql module do.

In my version, user can just read bigint data by add "supportBigNumbers", "bigNumberStrings" to connection, to get precise data.

const knex = require('../knex')

const instance = knex({
    client: 'better-sqlite3',
    connection: {
      filename: './data.db',
      supportBigNumbers: true,
      bigNumberStrings: true,
    },
    useNullAsDefault: true
  })

const conn = instance('addresses');

conn.select('*')
conn.first();
conn.where('id',1);
conn.then(res=>console.log({res}))

[KlausBai]

@kibertoad can you make a review for me ?

[OlivierCavadenti]

Can be simplified with:

const processBigintModeRow = (row) => {
  return mapValues(row, v => {
    if (typeof v === 'bigint') {
      const numV = Number(v);
      if (numV === v) {
        return numV;
      } else if (bigNumberStrings) {
        return v.toString()
      }
    }
    return v
  })
}

[KlausBai]

You are right, this function can be simplified. However, there may be a problem with 'numV === v' because 1n === 1 is false.