feat(kno-3533): schedules support #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanazam
commented
May 3, 2023
| @@ -126,6 +126,14 @@ private static string UrlEncodeAndClean(string value) | |||
| result.Add(new KeyValuePair<string, string>(key, s)); | |||
| break; | |||
|
|
|||
| case int i: | |||
| result.Add(new KeyValuePair<string, string>(key, i.ToString())); | |||
There was a problem hiding this comment.
Found out passing options like page_size: 1 was not working unless using a string instead of a number.
Decided to fix it.
juanazam
commented
May 3, 2023
| @@ -23,7 +23,7 @@ public class MessagesResource : BaseResource | |||
| /// <returns>A paginated Message response.</returns> | |||
| public async Task<PaginatedResponse<Message>> List(Dictionary<string, object> options = null) | |||
| { | |||
| if (options.ContainsKey("trigger_data")) | |||
| if (options != null && options.ContainsKey("trigger_data")) | |||
There was a problem hiding this comment.
The default options value is null, so this was breaking when not passing an options Dictionary
juanazam
force-pushed
the
jazambuja-kno-3533-dotnet-skd-add-schedules-support
branch
from
a596cc2
to
fe4f73b
Compare
juanazam
requested review from
brentjanderson,
cjbell,
thomaswhyyou,
bceskavich and
francoborr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for working with workflow schedules:
Also fixes 2 bugs: