Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: object preferences and unset channel data #3

Merged
merged 1 commit into from
May 10, 2022

Conversation

cjbell
Copy link
Contributor

@cjbell cjbell commented May 2, 2022

No description provided.

@cjbell cjbell requested review from a team, brentjanderson, juanazam and meryldakin and removed request for a team May 2, 2022 16:55
Copy link
Contributor

@juanazam juanazam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Didn't test all endpoints but the ones that tested worked!

Copy link
Contributor

@brentjanderson brentjanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit on periods, but otherwise seems legit.

@@ -165,6 +170,27 @@ public async Task<ChannelData> SetChannelData(string collection, string objectId
return await Client.MakeAPIRequest<ChannelData>(request, cancellationToken);
}

/// <summary>
/// Sets the channel data for the object on the channel provided.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: As a matter of consistency, do we want each summary to end with a period or not? The others don't end in a period. Some of the parameters do, however.

@cjbell cjbell merged commit 418ae04 into main May 10, 2022
@cjbell cjbell deleted the cjbell-kno-1264-sdks-object-preferences-support branch May 10, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants