fix: delete reference functions when a field is removed

Author: joelmukuthu

lib/KnormRelations.js

@@ -65,10 +65,14 @@ class KnormRelations {
         const { name, references } = field;
 
         if (references) {
-          const model = references.model.name;
-          delete this._config.references[model][name];
-          if (!Object.keys(this._config.references[model]).length) {
-            delete this._config.references[model];
+          if (typeof references === 'function') {
+            delete this._config.referenceFunctions[name];
+          } else {
+            const model = references.model.name;
+            delete this._config.references[model][name];
+            if (!Object.keys(this._config.references[model]).length) {
+              delete this._config.references[model];
+            }
           }
         }
       }

test/KnormRelations.spec.js

@@ -218,7 +218,6 @@ describe('KnormRelations', () => {
             Foo: { fooId: Quux.fields.fooId, fooId2: Quux.fields.fooId2 }
           });
         });
-      });
 
       describe('when a field is removed', () => {
         it('removes the field', () => {
@@ -249,6 +248,26 @@ describe('KnormRelations', () => {
           Bar.removeField(Bar.fields.barId);
           expect(Bar.config.references, 'to be empty');
         });
+
+        it("removes the field's reference function", () => {
+          class Foo extends Model {}
+          class Bar extends Model {}
+
+          Foo.fields = { id: { type: 'integer' } };
+          Bar.fields = {
+            id: 'integer',
+            fooId: {
+              type: 'integer',
+              references() {
+                return Foo.fields.id;
+              }
+            }
+          };
+
+          expect(Bar.config.referenceFunctions, 'to have key', 'fooId');
+          Bar.removeField(Bar.fields.fooId);
+          expect(Bar.config.referenceFunctions, 'to be empty');
+        });
       });
     });
   });