Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vite migration #144

Merged
merged 10 commits into from
Apr 7, 2023
Merged

Vite migration #144

merged 10 commits into from
Apr 7, 2023

Conversation

synnovsh
Copy link
Collaborator

@synnovsh synnovsh commented Mar 28, 2023 •
edited
Loading

Migrate away from CRA/react-scripts to Vite.

Follows migration steps outlined here. Changes in environment variables names, and linting rules that were previously a part of react-scripts.

Closes #142

@synnovsh synnovsh marked this pull request as draft March 28, 2023 09:39
@synnovsh synnovsh closed this Mar 28, 2023
@synnovsh synnovsh reopened this Mar 28, 2023
@synnovsh synnovsh requested review from andersrebner and krisstam and removed request for andersrebner and krisstam March 29, 2023 08:31
@synnovsh synnovsh marked this pull request as ready for review March 29, 2023 09:19
@synnovsh synnovsh marked this pull request as draft March 29, 2023 09:42
krisstam
krisstam reviewed Mar 29, 2023
View reviewed changes
Copy link
Contributor

@krisstam krisstam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeg skal ta en sjekk på dette etterhvert, men foreløpig så ser det veldig lovende ut

@synnovsh
Copy link
Collaborator Author

synnovsh commented Mar 29, 2023 •
edited
Loading

Når man kjører dette lokalt får man flere warnings i konsollen, men dette fikses ved oppgradering til React 17 som jeg tar i en ny PR

Edit: dette er ikke sant, det er antageligvis pga svg-er, skal utforske
Edit2: fixd

andersrebner
andersrebner requested changes Mar 29, 2023
View reviewed changes
frontend/package.json Outdated Show resolved Hide resolved
@andersrebner
Copy link
Collaborator

Ser bra ut! Merkbart hvor mye raskere dev-serveren starter 🚀

@synnovsh synnovsh marked this pull request as ready for review March 30, 2023 06:02
@synnovsh synnovsh marked this pull request as draft March 30, 2023 07:01
@synnovsh synnovsh mentioned this pull request Mar 30, 2023
Merged
@synnovsh synnovsh marked this pull request as ready for review March 31, 2023 06:34
krisstam
krisstam approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@krisstam krisstam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Endelig litt tid til å teste ut. Ser veldig bra ut dette, og fikk ingen problemer når jeg satt opp prosjektet på laptopen min, så da får jeg vel endelig Approve 😄

frontend/package.json Outdated Show resolved Hide resolved
@synnovsh synnovsh merged commit f6864c1 into main Apr 7, 2023
@synnovsh synnovsh mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krisstam krisstam krisstam approved these changes

@andersrebner andersrebner andersrebner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bytte fra CRA/react-scripts i frontend
3 participants
@synnovsh @andersrebner @krisstam