[Streaming][Kraken] Fixed bug that caused invalid WebSocket Extension handshake message.

[nielsdraaisma]

Fixed a bug in the Kraken streaming client that started today resulting in the following error

Caused by: io.netty.handler.codec.CodecException: invalid WebSocket Extension handshake for "permessage-deflate; client_no_context_takeover"

Relates to netty/netty#10191 , this change reuses the existing CoinbasePro handler which i moved to streaming-core-netty.

[mdvx]

ah good, was just about to look into that

[mdvx]

umm, still getting errors from unit test (after applying patch)

info.bitrich.xchangestream.kraken.KrakenManualExample

18:29:28.085 [main] INFO info.bitrich.xchangestream.kraken.KrakenStreamingService - Connecting to wss://ws.kraken.com
18:29:28.106 [main] DEBUG io.netty.util.internal.logging.InternalLoggerFactory - Using SLF4J as the default logging framework
18:29:28.130 [main] DEBUG io.netty.util.internal.PlatformDependent - Platform: Windows
18:29:28.133 [main] DEBUG io.netty.util.internal.PlatformDependent0 - -Dio.netty.noUnsafe: false
18:29:28.133 [main] DEBUG io.netty.util.internal.PlatformDependent0 - Java version: 11
18:29:28.136 [main] DEBUG io.netty.util.internal.PlatformDependent0 - sun.misc.Unsafe.theUnsafe: available
18:29:28.137 [main] DEBUG io.netty.util.internal.PlatformDependent0 - sun.misc.Unsafe.copyMemory: available
18:29:28.139 [main] DEBUG io.netty.util.internal.PlatformDependent0 - java.nio.Buffer.address: available
18:29:28.144 [main] DEBUG io.netty.util.internal.PlatformDependent0 - direct buffer constructor: unavailable
java.lang.UnsupportedOperationException: Reflective setAccessible(true) disabled
at io.netty.util.internal.ReflectionUtil.trySetAccessible(ReflectionUtil.java:31)
at io.netty.util.internal.PlatformDependent0$4.run(PlatformDependent0.java:238)
at java.base/java.security.AccessController.doPrivileged(Native Method)
at io.netty.util.internal.PlatformDependent0.(PlatformDependent0.java:232)
at io.netty.util.internal.PlatformDependent.isAndroid(PlatformDependent.java:293)
at io.netty.util.internal.PlatformDependent.(PlatformDependent.java:92)
at io.netty.handler.ssl.OpenSsl.(OpenSsl.java:124)
at io.netty.handler.ssl.SslContext.defaultProvider(SslContext.java:123)
at io.netty.handler.ssl.SslContext.defaultClientProvider(SslContext.java:119)
at io.netty.handler.ssl.SslContext.newClientContextInternal(SslContext.java:814)
at io.netty.handler.ssl.SslContextBuilder.build(SslContextBuilder.java:576)
at info.bitrich.xchangestream.service.netty.NettyStreamingService.lambda$openConnection$3(NettyStreamingService.java:177)

I am using JDK 11, if that helps

[nielsdraaisma]

umm, still getting errors from unit test (after applying patch)

info.bitrich.xchangestream.kraken.KrakenManualExample

18:29:28.085 [main] INFO info.bitrich.xchangestream.kraken.KrakenStreamingService - Connecting to wss://ws.kraken.com
18:29:28.106 [main] DEBUG io.netty.util.internal.logging.InternalLoggerFactory - Using SLF4J as the default logging framework
18:29:28.130 [main] DEBUG io.netty.util.internal.PlatformDependent - Platform: Windows
18:29:28.133 [main] DEBUG io.netty.util.internal.PlatformDependent0 - -Dio.netty.noUnsafe: false
18:29:28.133 [main] DEBUG io.netty.util.internal.PlatformDependent0 - Java version: 11
18:29:28.136 [main] DEBUG io.netty.util.internal.PlatformDependent0 - sun.misc.Unsafe.theUnsafe: available
18:29:28.137 [main] DEBUG io.netty.util.internal.PlatformDependent0 - sun.misc.Unsafe.copyMemory: available
18:29:28.139 [main] DEBUG io.netty.util.internal.PlatformDependent0 - java.nio.Buffer.address: available
18:29:28.144 [main] DEBUG io.netty.util.internal.PlatformDependent0 - direct buffer constructor: unavailable
java.lang.UnsupportedOperationException: Reflective setAccessible(true) disabled
at io.netty.util.internal.ReflectionUtil.trySetAccessible(ReflectionUtil.java:31)
at io.netty.util.internal.PlatformDependent0$4.run(PlatformDependent0.java:238)
at java.base/java.security.AccessController.doPrivileged(Native Method)
at io.netty.util.internal.PlatformDependent0.(PlatformDependent0.java:232)
at io.netty.util.internal.PlatformDependent.isAndroid(PlatformDependent.java:293)
at io.netty.util.internal.PlatformDependent.(PlatformDependent.java:92)
at io.netty.handler.ssl.OpenSsl.(OpenSsl.java:124)
at io.netty.handler.ssl.SslContext.defaultProvider(SslContext.java:123)
at io.netty.handler.ssl.SslContext.defaultClientProvider(SslContext.java:119)
at io.netty.handler.ssl.SslContext.newClientContextInternal(SslContext.java:814)
at io.netty.handler.ssl.SslContextBuilder.build(SslContextBuilder.java:576)
at info.bitrich.xchangestream.service.netty.NettyStreamingService.lambda$openConnection$3(NettyStreamingService.java:177)

I am using JDK 11, if that helps

This PR doesn't address these errors, i'm seeing them locally as well, it only addresses the problem described in the linked issue in the netty repo.

[earce]

Thank you guys for getting this out so quickly, I just had a patch ready and you folks had beat me to it!

[nielsdraaisma]

Would be great if @badgerwithagun or @timmolter could merge this in, travis build failed due to a failure to download a dependency, should be fine aside from that.

[earce]

Are you guys seeing any issues with the actual parsing of messages now?

[earce]

@mdvx @nielsdraaisma

[earce]

please ignore my comments, an issue on my end

[mdvx]

confirm fixed for me too
only other change I made was
okhttp-version 3.13.1
to
okhttp-version 4.7.2