Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate Memory Footprint of the Dictionary #339

Closed
aannleax opened this issue Aug 10, 2023 · 0 comments · Fixed by #527
Closed

Calculate Memory Footprint of the Dictionary #339

aannleax opened this issue Aug 10, 2023 · 0 comments · Fixed by #527
Assignees
@mkroetzsch
Labels
dictionary enhancement New feature or request
Milestone
Release 0.6.0

Comments

@aannleax
Copy link
Member

Since the dictionary can consume quite a lot of memory it would be nice if it was visible in the output introduced by #338.

This would involve implementing the ByteSized trait for the dictionary and adding a new subblock to the MemoryUsage object created in the memory_usage function of the TableManager.
@aannleax aannleax added the enhancement New feature or request label Aug 10, 2023
@aannleax aannleax added this to the Release 0.4.0 milestone Aug 10, 2023
@mmarx mmarx modified the milestones: Release 0.4.0, Release 0.5.0 Nov 20, 2023
@aannleax aannleax assigned mkroetzsch and unassigned mkroetzsch and ellmau Mar 27, 2024
@mmarx mmarx modified the milestones: Release 0.5.0, Release 0.6.0 Apr 3, 2024
@mkroetzsch mkroetzsch mentioned this issue Sep 6, 2024
Merged
@mmarx mmarx closed this as completed in #527 Sep 9, 2024
mmarx added a commit that referenced this issue Sep 9, 2024
@mmarx
Compute and report dictionary size (#527)
d675b5d 
This pull request fixes #339 and integrates the result in the reporting
on the command line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkroetzsch mkroetzsch

Labels
dictionary enhancement New feature or request
Projects
nemo
Archived in project
Milestone
Release 0.6.0
Development

Successfully merging a pull request may close this issue.

Compute and report dictionary size knowsys/nemo
5 participants
@mkroetzsch @mmarx @monsterkrampe @aannleax @ellmau