Add simple benchmarks for in-/output handling #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monsterkrampe
added
enhancement
monsterkrampe
commented
Jul 17, 2023
Comment on lines
+108
to
+135
| serialized_output.bench_function("strings_in_logical_any", |b| { | ||
| b.iter_batched( | ||
| || physical_strings.clone(), | ||
| |output| { | ||
| for _ in PrimitiveType::Any | ||
| .serialize_output(DataValueIteratorT::String(Box::new(output.into_iter()))) | ||
| { | ||
| } | ||
| }, | ||
| BatchSize::SmallInput, | ||
| ) | ||
| }); | ||
|
|
||
| serialized_output.bench_function("constants_in_logical_any", |b| { | ||
| b.iter_batched( | ||
| || physical_constants.clone(), | ||
| |output| { | ||
| for _ in PrimitiveType::Any | ||
| .serialize_output(DataValueIteratorT::String(Box::new(output.into_iter()))) | ||
| { | ||
| } | ||
| }, | ||
| BatchSize::SmallInput, | ||
| ) | ||
| }); | ||
|
|
||
| serialized_output.finish(); | ||
| } |
There was a problem hiding this comment.
Interestingly, out of these two the latter is noticeably faster. I did not investigate this too much but I would have expected them to have more or less the same performance.
monsterkrampe
force-pushed
the
input-output-benchmarks
branch
from
9bfae1a
to
df84125
Compare
mmarx
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #311
A quick idea for benchmarks for the logical input-/output mappings.