parser: section getKey handle sections with same name #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
mvdan
approved these changes
Nov 14, 2018
|
@vishen note that you seem to have broken some tests, though. |
|
Opps, let me fix them! |
Previously, the section getKey would return keys for the first section found. If there is more than one section with the same name, the first section was always used when searching for keys in those sections. This is because it loops through all the file lines looking for a section with the same name, and the first one declared was always foudn first. Use the section position, rather than name, to determine the section we are looking for keys for.
vishen
force-pushed
the
getkey_sections_with_same_name
branch
from
0e4d8f2 to
e8b73a8
Compare
|
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the section getKey would return keys for the first section
found. If there is more than one section with the same name, the first
section was always used when searching for keys in those sections. This
is because it loops through all the file lines looking for a section
with the same name, and the first one declared was always foudn first.
Use the section position, rather than name, to determine the section we
are looking for keys for.