Fix build constraints for OSes other than Linux #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: knqyf263 <knqyf263@gmail.com>
knqyf263
changed the title
yjqg6666
added a commit
to yjqg6666/k9s
that referenced
this pull request
Jul 3, 2024
fix build error: vendor/github.com/knqyf263/go-rpmdb/pkg/ndb/ndb.go:99:8: undefined: syscallFlock vendor/github.com/knqyf263/go-rpmdb/pkg/ndb/ndb.go:99:37: undefined: syscallLOCK_SH vendor/github.com/knqyf263/go-rpmdb/pkg/ndb/ndb.go:135:6: undefined: syscallFlock vendor/github.com/knqyf263/go-rpmdb/pkg/ndb/ndb.go:135:38: undefined: syscallLOCK_UN Related to issue knqyf263/go-rpmdb#53.
derailed
pushed a commit
to derailed/k9s
that referenced
this pull request
Jul 7, 2024
fix build error: vendor/github.com/knqyf263/go-rpmdb/pkg/ndb/ndb.go:99:8: undefined: syscallFlock vendor/github.com/knqyf263/go-rpmdb/pkg/ndb/ndb.go:99:37: undefined: syscallLOCK_SH vendor/github.com/knqyf263/go-rpmdb/pkg/ndb/ndb.go:135:6: undefined: syscallFlock vendor/github.com/knqyf263/go-rpmdb/pkg/ndb/ndb.go:135:38: undefined: syscallLOCK_UN Related to issue knqyf263/go-rpmdb#53.
djoreilly
pushed a commit
to djoreilly/go-rpmdb
that referenced
this pull request
Nov 6, 2024
Signed-off-by: knqyf263 <knqyf263@gmail.com> (cherry picked from commit facee9e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After this change, this library cannot be used for FreeBSD or other OSes than Linux, macOS and Windows. Since the purpose of #48 is to avoid conflicts due to RPMDB updates, it is considered sufficient to lock only on Linux. Therefore, this PR does not lock on other operating systems and can be compiled for other platforms.