Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix execution of command with quotes on windows. #241

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Fix execution of command with quotes on windows. #241

merged 2 commits into from
Feb 1, 2024

Conversation

matrixx567
Copy link
Contributor

Issue
#138 #238

Description of changes:

Commands with quotes can't be handled on windows using standard exec.Command() calls. Based on the go documentation https://pkg.go.dev/os/exec#Command the argument handling is converted to SysProcAttr.

Split run function into OS dependent source files.

@matrixx567
Fix execution of command with quotes on windows.
66c2575 
Commands with quotes can't be handled on windows using standard
exec.Command() calls. Based on the go documentation
https://pkg.go.dev/os/exec#Command the argument handling is converted
to SysProcAttr.
@matrixx567
Split run function into separate files for OS builds.
6467d36
@matrixx567 matrixx567 marked this pull request as ready for review January 29, 2024 14:07
@RamiAwar
Copy link
Collaborator

Thanks for the PR @matrixx567! Everything LGTM.

Will need a few days to test it and double check everything runs fine (currently traveling, no windows machine), but will merge it asap.

@RamiAwar RamiAwar added the bug label Jan 29, 2024
@RamiAwar
Copy link
Collaborator

RamiAwar commented Feb 1, 2024 •
edited
Loading

Hey @matrixx567, thanks for the PR. Tested it out and it looks good.

To be clear on how I tested:
I tried building pet without these changes and ran it on windows with the command echo "hello world"
This resulted in: \"hello world\"

Tried building pet on your branch and ran it again with the same input and I got "hello world".

@RamiAwar RamiAwar merged commit 988e248 into knqyf263:main Feb 1, 2024
1 check passed
RamiAwar added a commit to sadayuki-matsuno/pet that referenced this pull request Apr 20, 2024
@RamiAwar
Squashed commit of the following:
d4b94c4 
commit e9e1947
Merge: 19dc6b2 0937d9a
Author: Rami Awar <RamiAwar@users.noreply.github.com>
Date:   Sat Apr 20 07:02:14 2024 +0200

    Merge pull request knqyf263#294 from Welding-Torch/main

    Make it work on Windows

commit 0937d9a
Author: Welding Torch <46340124+Welding-Torch@users.noreply.github.com>
Date:   Sat Apr 20 09:02:01 2024 +0530

    Make it work on Windows

    Fuzzy Finder needs a slightly different prompt in order to work on Windows.

commit 19dc6b2
Merge: a1ba29e 95c69fe
Author: Rami Awar <RamiAwar@users.noreply.github.com>
Date:   Tue Mar 5 16:44:11 2024 +0100

    Merge pull request knqyf263#290 from knqyf263/multiple-default-param-support

    Added multiple parameter support via two character separators

commit 95c69fe
Author: Rami Awar <rami.awar.ra@gmail.com>
Date:   Tue Mar 5 16:43:10 2024 +0100

    refactor: Improved readability, changed select to circular

commit 05981b7
Author: Rami Awar <rami.awar.ra@gmail.com>
Date:   Tue Mar 5 16:08:43 2024 +0100

    fix: Fixed bug with multiple default values, added hint

commit 3cd490f
Author: Rami Awar <rami.awar.ra@gmail.com>
Date:   Fri Mar 1 00:06:34 2024 +0100

    docs: Added docs about multiple default parameters

commit 232ea0b
Author: Rami Awar <rami.awar.ra@gmail.com>
Date:   Wed Feb 28 23:07:24 2024 +0100

    Added multiple parameter support via two character separators

commit a1ba29e
Merge: 4e7458f 11a8197
Author: Rami Awar <RamiAwar@users.noreply.github.com>
Date:   Wed Feb 28 16:50:19 2024 +0100

    Merge pull request knqyf263#259 from jaroslawhartman/pet-main-knqyf263-views-size

    Parameters width and position modification

commit 11a8197
Author: Rami Awar <rami.awar.ra@gmail.com>
Date:   Wed Feb 28 16:49:01 2024 +0100

    style: Removed unused variables

commit 9f134e1
Merge: b1337a9 4e7458f
Author: Rami Awar <RamiAwar@users.noreply.github.com>
Date:   Wed Feb 28 16:41:29 2024 +0100

    Merge branch 'main' into pet-main-knqyf263-views-size

commit b1337a9
Author: Rami Awar <rami.awar.ra@gmail.com>
Date:   Wed Feb 28 16:39:42 2024 +0100

    Altered max lengths of parameters, aligned to left

commit 4e7458f
Author: Rami Awar <rami.awar.ra@gmail.com>
Date:   Tue Feb 20 09:57:41 2024 +0100

    fix: :bug: Allow equal signs in param default values

    Closes knqyf263#119

commit ef34cb4
Author: Rami Awar <RamiAwar@users.noreply.github.com>
Date:   Sun Feb 18 01:00:11 2024 +0100

    Create codeql.yml

commit aac8e6e
Merge: b969b98 e9a69d0
Author: Rami Awar <RamiAwar@users.noreply.github.com>
Date:   Sun Feb 18 00:58:37 2024 +0100

    Merge pull request knqyf263#279 from knqyf263/dependabot/go_modules/golang.org/x/crypto-0.17.0

    build(deps): bump golang.org/x/crypto from 0.0.0-20200622213623-75b288015ac9 to 0.17.0

commit e9a69d0
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Sat Feb 17 23:57:48 2024 +0000

    build(deps): bump golang.org/x/crypto

    Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.0.0-20200622213623-75b288015ac9 to 0.17.0.
    - [Commits](https://github.com/golang/crypto/commits/v0.17.0)

    ---
    updated-dependencies:
    - dependency-name: golang.org/x/crypto
      dependency-type: direct:production
    ...

    Signed-off-by: dependabot[bot] <support@github.com>

commit b969b98
Merge: a8bccd1 9d68cbb
Author: Rami Awar <RamiAwar@users.noreply.github.com>
Date:   Sun Feb 18 00:57:10 2024 +0100

    Merge pull request knqyf263#278 from knqyf263/dependabot/go_modules/golang.org/x/net-0.17.0

    build(deps): bump golang.org/x/net from 0.0.0-20201021035429-f5854403a974 to 0.17.0

commit 9d68cbb
Merge: cb9fcf0 a8bccd1
Author: Rami Awar <RamiAwar@users.noreply.github.com>
Date:   Sun Feb 18 00:57:04 2024 +0100

    Merge branch 'main' into dependabot/go_modules/golang.org/x/net-0.17.0

commit cb9fcf0
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Sat Feb 17 23:55:06 2024 +0000

    build(deps): bump golang.org/x/net

    Bumps [golang.org/x/net](https://github.com/golang/net) from 0.0.0-20201021035429-f5854403a974 to 0.17.0.
    - [Commits](https://github.com/golang/net/commits/v0.17.0)

    ---
    updated-dependencies:
    - dependency-name: golang.org/x/net
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <support@github.com>

commit a8bccd1
Merge: 3a9e083 73acc26
Author: Rami Awar <RamiAwar@users.noreply.github.com>
Date:   Sun Feb 18 00:54:57 2024 +0100

    Merge pull request knqyf263#277 from knqyf263/dependabot/go_modules/golang.org/x/text-0.3.8

    build(deps): bump golang.org/x/text from 0.3.3 to 0.3.8

commit 73acc26
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Sat Feb 17 23:54:07 2024 +0000

    build(deps): bump golang.org/x/text from 0.3.3 to 0.3.8

    Bumps [golang.org/x/text](https://github.com/golang/text) from 0.3.3 to 0.3.8.
    - [Release notes](https://github.com/golang/text/releases)
    - [Commits](golang/text@v0.3.3...v0.3.8)

    ---
    updated-dependencies:
    - dependency-name: golang.org/x/text
      dependency-type: indirect
    ...

    Signed-off-by: dependabot[bot] <support@github.com>

commit 3a9e083
Author: Rami Awar <rami.awar.ra@gmail.com>
Date:   Sat Feb 17 02:29:01 2024 +0100

    fix: Fixes knqyf263#166

commit f0a32cc
Author: Rami Awar <rami.awar.ra@gmail.com>
Date:   Sat Feb 17 02:21:03 2024 +0100

    fix: :bug: Fixed knqyf263#150

    Parameters were getting extracted from the command as well as the description or tags. Changed this to only extract parameters out of the command.

    150

commit dbc472b
Author: Rami Awar <rami.awar.ra@gmail.com>
Date:   Sat Feb 10 11:44:12 2024 +0100

    feat: :zap: Improve regex pattern

    Closes knqyf263#270

commit 6d0fa33
Author: Rami Awar <rami.awar.ra@gmail.com>
Date:   Sat Feb 10 09:37:25 2024 +0100

    style: :sparkles: Changed default select cmd, added high contrast colors

    Closes knqyf263#265

commit a6efb9a
Author: Rami Awar <RamiAwar@users.noreply.github.com>
Date:   Sat Feb 10 08:54:12 2024 +0100

    Update README.md

commit 521dc0a
Author: Rami Awar <RamiAwar@users.noreply.github.com>
Date:   Sat Feb 10 08:53:41 2024 +0100

    Update README.md

commit ba256cc
Author: Rami Awar <RamiAwar@users.noreply.github.com>
Date:   Sat Feb 10 08:51:30 2024 +0100

    Update README.md

commit c17deaf
Author: Rami Awar <rami.awar.ra@gmail.com>
Date:   Fri Feb 9 23:33:03 2024 +0100

    feat: :lipstick: Refactored new command to allow empty tags instead of cancelling

commit 32dc483
Merge: 068cbf5 557459d
Author: Rami Awar <RamiAwar@users.noreply.github.com>
Date:   Fri Feb 9 22:35:51 2024 +0100

    Merge pull request knqyf263#256 from crpb/tempfile

    new: tempfile-handling

commit 068cbf5
Merge: bed4fc6 cf11afa
Author: Rami Awar <RamiAwar@users.noreply.github.com>
Date:   Wed Feb 7 08:36:17 2024 +0100

    Merge pull request knqyf263#142 from cxfcxf/change_output

    Print out executed command by default

commit cf11afa
Author: Rami Awar <rami.awar.ra@gmail.com>
Date:   Tue Feb 6 23:02:26 2024 +0100

    refactor: Removed unnecessary import and debug statement

commit 236e0d8
Merge: 60d03d7 bed4fc6
Author: Rami Awar <rami.awar.ra@gmail.com>
Date:   Tue Feb 6 22:58:26 2024 +0100

    Merge branch 'main' into change_output

commit 60d03d7
Author: Xuefeng Chen <xchen@magnite.com>
Date:   Tue Feb 6 13:53:46 2024 -0800

    change_output: set it as default

commit bed4fc6
Author: Rami Awar <rami.awar.ra@gmail.com>
Date:   Mon Feb 5 21:44:45 2024 +0100

    Removed blank issues option

commit 4ca83c9
Author: Rami Awar <rami.awar.ra@gmail.com>
Date:   Sat Feb 3 10:37:52 2024 +0100

    Updated issue template

commit 47d9acd
Author: Rami Awar <rami.awar.ra@gmail.com>
Date:   Sat Feb 3 10:35:10 2024 +0100

    Added security policies

commit 7a4b57e
Author: Rami Awar <rami.awar.ra@gmail.com>
Date:   Sat Feb 3 10:29:51 2024 +0100

    Added issue template

commit d142511
Author: Rami Awar <rami.awar.ra@gmail.com>
Date:   Fri Feb 2 23:33:11 2024 +0100

    fix: :bug: Restore run function to all platforms, remove deprecated flag

commit 19d7ee7
Merge: 91be065 4355252
Author: Rami Awar <RamiAwar@users.noreply.github.com>
Date:   Fri Feb 2 22:40:53 2024 +0100

    Merge pull request knqyf263#261 from knqyf263/unused-variable-cleanup-and-tag

    Removed unused variable

commit 4355252
Author: Rami Awar <rami.awar.ra@gmail.com>
Date:   Fri Feb 2 22:40:12 2024 +0100

    Removed unused variable

commit 91be065
Merge: b5974c2 2864c1e
Author: Rami Awar <RamiAwar@users.noreply.github.com>
Date:   Fri Feb 2 22:24:14 2024 +0100

    Merge pull request knqyf263#260 from knqyf263/support-for-parameter-order-maintenance

    feat: ✨ Added order to parameters based on order of occurrence

commit 2864c1e
Author: Rami Awar <rami.awar.ra@gmail.com>
Date:   Fri Feb 2 22:22:41 2024 +0100

    feat: :sparkles: Added order to parameters based on order of occurrence

    Closes knqyf263#258.

commit 2b9f1cf
Author: Jaroslaw Hartman <jaroslaw.hartman@oracle.com>
Date:   Fri Feb 2 18:49:33 2024 +0100

    Parameters width and position modification

commit b5974c2
Merge: 988e248 be2b04c
Author: Rami Awar <RamiAwar@users.noreply.github.com>
Date:   Fri Feb 2 09:37:07 2024 +0100

    Merge pull request knqyf263#257 from knqyf263/insert-params-bugfix

    fix: 🐛 Updated insert params to match new search format

commit be2b04c
Author: Rami Awar <rami.awar.ra@gmail.com>
Date:   Fri Feb 2 09:33:02 2024 +0100

    fix: :bug: Updated insert params to match new search format

commit 988e248
Merge: e1b209b 6467d36
Author: Rami Awar <RamiAwar@users.noreply.github.com>
Date:   Thu Feb 1 22:56:18 2024 +0100

    Merge pull request knqyf263#241 from matrixx567/win_cmd_quote

    Fix execution of command with quotes on windows.

commit 557459d
Author: cb <christopher@bocki.com>
Date:   Thu Feb 1 17:56:35 2024 +0100

    new: tempfile-handling

commit e1b209b
Merge: 3061931 35de514
Author: Rami Awar <RamiAwar@users.noreply.github.com>
Date:   Thu Feb 1 00:24:43 2024 +0100

    Merge pull request knqyf263#253 from chris-short/patch-1

    Update README.md

commit 35de514
Author: Chris "Not So" Short <chrisshort@duck.com>
Date:   Wed Jan 31 15:15:46 2024 -0500

    Update README.md

    Aligning TOC

commit 3061931
Merge: f1c08dd f9de45f
Author: Rami Awar <RamiAwar@users.noreply.github.com>
Date:   Tue Jan 30 10:24:23 2024 +0100

    Merge pull request knqyf263#244 from knqyf263/additional-params-test-for-EOF-command

    test: 🧪 Added test

commit f9de45f
Author: Rami Awar <rami.awar.ra@gmail.com>
Date:   Tue Jan 30 10:23:23 2024 +0100

    test: :test_tube: Added test

    Copied from knqyf263#224

commit f1c08dd
Merge: b5abca3 6302255
Author: Rami Awar <RamiAwar@users.noreply.github.com>
Date:   Tue Jan 30 09:23:20 2024 +0100

    Merge pull request knqyf263#243 from knqyf263/update-gocui

    feat: ⚡ Updated gocui to community fork

commit 6302255
Author: Rami Awar <rami.awar.ra@gmail.com>
Date:   Tue Jan 30 01:38:28 2024 +0100

    feat: :zap: Updated gocui to community fork

    - Updated gocui to more maintained community fork (awesome-gocui)

    Closes knqyf263#41, knqyf263#179, knqyf263#132

commit b5abca3
Merge: ac91ac6 66fdce2
Author: Rami Awar <RamiAwar@users.noreply.github.com>
Date:   Mon Jan 29 16:40:30 2024 +0100

    Merge pull request knqyf263#242 from knqyf263/parameter-parsing-bug-fixes

    fix: 🐛 Fixed parsing of parameters, added tests

commit 66fdce2
Author: Rami Awar <rami.aawar@sendcloud.com>
Date:   Mon Jan 29 16:19:43 2024 +0100

    fix: :bug: Fixed parsing of parameters, added tests

    - Fixed regex string for extracting parameters (`<([\S].+?[\S])>` did not work for single character variables, changed to `<([\S]+?)>`)
    - Improved extraction logic by taking key without <>
    - Added tests for parameter parsing

    Closes knqyf263#159, knqyf263#206.

commit 6467d36
Author: martin <martin@mnprojects.net>
Date:   Mon Jan 29 15:00:19 2024 +0100

    Split run function into separate files for OS builds.

commit ac91ac6
Author: Teppei Fukuda <knqyf263@gmail.com>
Date:   Thu Jan 25 10:52:26 2024 +0400

    Revert "Fix execution of command with quotes on windows." (knqyf263#240)

commit 4c51204
Author: Martin Nöhrer <martin@mnprojects.net>
Date:   Tue Jan 23 15:02:33 2024 +0100

    Fix execution of command with quotes on windows. (knqyf263#238)

    Commands with quotes can't be handled on windows using standard
    exec.Command() calls. Based on the go documentation
    https://pkg.go.dev/os/exec#Command the argument handling is converted
    to SysProcAttr.

commit 66c2575
Author: martin <martin@mnprojects.net>
Date:   Tue Jan 23 14:21:40 2024 +0100

    Fix execution of command with quotes on windows.

    Commands with quotes can't be handled on windows using standard
    exec.Command() calls. Based on the go documentation
    https://pkg.go.dev/os/exec#Command the argument handling is converted
    to SysProcAttr.

commit 4304034
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Dec 7 14:46:25 2023 +0400

    Bump actions/setup-go from 4 to 5 (knqyf263#235)

    Bumps [actions/setup-go](https://github.com/actions/setup-go) from 4 to 5.
    - [Release notes](https://github.com/actions/setup-go/releases)
    - [Commits](actions/setup-go@v4...v5)

    ---
    updated-dependencies:
    - dependency-name: actions/setup-go
      dependency-type: direct:production
      update-type: version-update:semver-major
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 590c14d
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Wed Oct 18 13:43:01 2023 +0900

    Bump actions/checkout from 4.1.0 to 4.1.1 (knqyf263#231)

commit d357774
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Sep 25 22:03:22 2023 +0300

    Bump actions/checkout from 4.0.0 to 4.1.0 (knqyf263#230)

    Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0.
    - [Release notes](https://github.com/actions/checkout/releases)
    - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
    - [Commits](actions/checkout@v4.0.0...v4.1.0)

    ---
    updated-dependencies:
    - dependency-name: actions/checkout
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...

    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 10fb0ef
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Sep 12 10:00:58 2023 +0300

    Bump goreleaser/goreleaser-action from 4 to 5 (knqyf263#228)

commit 45ca4aa
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Sep 5 08:46:54 2023 +0300

    Bump actions/checkout from 3.6.0 to 4.0.0 (knqyf263#227)

commit 643233a
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Fri Aug 25 07:38:26 2023 +0300

    Bump actions/checkout from 3.5.3 to 3.6.0 (knqyf263#226)

commit d485fb0
Author: guangwu <guoguangwu@magic-shield.com>
Date:   Thu Jul 13 16:17:28 2023 +0800

    chore: remove refs to deprecated io/ioutil (knqyf263#225)

commit 9d1e8b1
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Jun 12 05:37:37 2023 +0300

    Bump actions/checkout from 3.5.2 to 3.5.3 (knqyf263#223)

commit 0b46f45
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue May 9 16:00:36 2023 +0300

    Bump actions/setup-go from 3 to 4 (knqyf263#221)

commit 51371af
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue May 9 11:48:04 2023 +0300

    Bump actions/checkout from 3.1.0 to 3.5.2 (knqyf263#222)

commit 4ae83c3
Author: knqyf263 <knqyf263@gmail.com>
Date:   Mon May 8 21:41:33 2023 +0300

    chore: bump GoReleaser

commit 8eac46d
Author: knqyf263 <knqyf263@gmail.com>
Date:   Mon May 8 21:12:26 2023 +0300

    fix: check out first

commit 7e3d737
Author: Teppei Fukuda <knqyf263@gmail.com>
Date:   Mon May 8 20:58:24 2023 +0300

    chore: bump Go to 1.20 (knqyf263#219)

commit ca40e1e
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon May 8 20:52:38 2023 +0300

    Bump goreleaser/goreleaser-action from 2 to 4 (knqyf263#213)

commit 0104f05
Author: Jakob Helmecke <37172067+helmecke@users.noreply.github.com>
Date:   Mon May 8 19:51:33 2023 +0200

    feat: add clip command (knqyf263#191)

    copy selected command to clipboard

commit 9b3e0fa
Author: Ch. König <cking@users.noreply.github.com>
Date:   Mon May 8 19:47:53 2023 +0200

    make command runner configurable (knqyf263#196)

    Co-authored-by: knqyf263 <knqyf263@gmail.com>

commit 803bc98
Author: Tobias Brumhard <code@brumhard.com>
Date:   Mon May 8 19:42:36 2023 +0200

    Add config option to overwrite used shell (knqyf263#200)

    Signed-off-by: Tobias Brumhard <code@brumhard.com>

commit 154052b
Author: Xing Yahao <keidarcy.1015@gmail.com>
Date:   Tue May 9 02:34:20 2023 +0900

    Update README.md (knqyf263#193)

    Co-authored-by: Teppei Fukuda <knqyf263@gmail.com>

commit 8e7dded
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon May 8 20:31:03 2023 +0300

    Bump actions/setup-go from 2 to 3 (knqyf263#198)

commit 407bb23
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon May 8 20:30:28 2023 +0300

    Bump actions/checkout from 2 to 3.1.0 (knqyf263#209)

commit 9a480aa
Author: Adrian Wyssmann <papanito@wyssmann.com>
Date:   Mon May 8 19:30:08 2023 +0200

    docu: add more info to gitlab sync (knqyf263#201)

commit 107362f
Author: John Olheiser <john.olheiser@gmail.com>
Date:   Mon May 8 12:29:04 2023 -0500

    Allow for env var to determine config dir (knqyf263#210)

    Signed-off-by: jolheiser <john.olheiser@gmail.com>

commit 9f42c4d
Author: K8sCat <k8scat@gmail.com>
Date:   Tue May 9 01:27:36 2023 +0800

    fix: panic while get gist failed (knqyf263#212)

commit e7a5e03
Author: Patrizio Bekerle <patrizio@bekerle.com>
Date:   Sun Nov 21 10:11:29 2021 +0100

    Fix typo in variables (knqyf263#188)

    * Fix typo

    * Update missing variable

commit 1617dff
Author: Teppei Fukuda <knqyf263@gmail.com>
Date:   Tue Nov 16 21:27:29 2021 +0200

    chore: use personal access token (knqyf263#186)

commit 7748558
Author: Nikita Fedyashev <nikita@sovereign.zone>
Date:   Tue Nov 16 21:13:59 2021 +0200

    Updated outdated wget URL (knqyf263#144)

commit 696df2b
Author: sadayuki-matsuno <sadayuki.matsuno@gmail.com>
Date:   Wed Nov 17 04:13:02 2021 +0900

    feat filter tag (knqyf263#172)

    * feat filter tag

    * add readme

commit 9595a5d
Author: Keyton Stanier <keyton@stanier.net>
Date:   Tue Nov 16 14:12:52 2021 -0500

    Fixed GitLab sync (knqyf263#174)

    * Fixed GitLab sync

    * remove cruft

    Co-authored-by: monke <monkey@cygen.network>
    Co-authored-by: knqyf263 <knqyf263@gmail.com>

commit c5e09b9
Author: Teppei Fukuda <knqyf263@gmail.com>
Date:   Tue Nov 16 21:09:01 2021 +0200

    chore(mod): update golang.org/x/sys (knqyf263#185)

commit a6cce27
Author: Teppei Fukuda <knqyf263@gmail.com>
Date:   Tue Nov 16 20:57:03 2021 +0200

    chore: migrate to GitHub Actions (knqyf263#184)

commit 582b255
Author: yutachaos <18604471+yutachaos@users.noreply.github.com>
Date:   Tue Nov 16 23:56:17 2021 +0900

    Added arm support (knqyf263#181)

commit 908f47c
Author: Joseph Ku <joseph@diing.com>
Date:   Tue Nov 16 22:54:51 2021 +0800

    Update the GoReleaser config file for GoReleaser v1.0.0 (knqyf263#182) (knqyf263#183)

commit dcaea2b
Author: Ryoga <eial5q265e5+github@gmail.com>
Date:   Mon Sep 6 18:01:23 2021 +0900

    Fix `--quote` with spaces (knqyf263#177)

commit 3819fd6
Author: xchen <xchen@rubiconproject.com>
Date:   Thu Sep 24 18:46:41 2020 -0700

    for igor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RamiAwar RamiAwar RamiAwar approved these changes

Assignees
No one assigned
Labels
bug
Projects
pet
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matrixx567 @RamiAwar