Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request : remove dependency to pedantic #8

Closed
tsimbalar opened this issue Feb 28, 2022 · 2 comments · Fixed by #9
Closed

Request : remove dependency to pedantic #8

tsimbalar opened this issue Feb 28, 2022 · 2 comments · Fixed by #9
Assignees
@tsimbalar
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tsimbalar
Copy link
Contributor

tsimbalar commented Feb 28, 2022 •
edited
Loading

The pedantic library is considered deprecated : see https://github.com/google/pedantic#readme .

There are migration instructions here : https://github.com/dart-lang/lints#migrating-from-packagepedantic .

unawaited is now available natively as part of dart:async so we could maybe rely on it instead, and remove the pedantic dependency all together ?

Thanks !
@robertohuertasm robertohuertasm added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 1, 2022
@robertohuertasm
Copy link
Contributor

Thanks @tsimbalar! Good to know! Happy to receive a PR is someone is up to the task! Adding Good first issue label just in case want to tackle this.

tsimbalar added a commit to tsimbalar/horizontal_blocked_scroll_physics that referenced this issue Mar 4, 2022
@tsimbalar
refactor(deps): remove pedantic dependency in favor of flutter_lints
0a46ade 
`pedantic` is deprecated, and has been superseeded by `flutter_lints`

See also : 
- Introducing `flutter_lints`  https://docs.flutter.dev/release/breaking-changes/flutter-lints-package
- Migration instructions :  https://github.com/dart-lang/lints#migrating-from-packagepedantic


fixes koa-health#8
@tsimbalar tsimbalar mentioned this issue Mar 4, 2022
Merged
@tsimbalar
Copy link
Contributor Author

here you go :

@tsimbalar tsimbalar self-assigned this Mar 4, 2022
tsimbalar added a commit that referenced this issue Mar 7, 2022
@tsimbalar
deps: remove dependency to pedantic (#9)
4c897b9 
* refactor(deps): remove `pedantic` dependency in favor of `flutter_lints`

`pedantic` is deprecated, and has been superseeded by `flutter_lints`

See also : 
- Introducing `flutter_lints`  https://docs.flutter.dev/release/breaking-changes/flutter-lints-package
- Migration instructions :  https://github.com/dart-lang/lints#migrating-from-packagepedantic


fixes #8

* chore(version): bumped to 4.0.1

no new functionality or expected changes, so just a patch version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsimbalar tsimbalar

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

deps: remove dependency to pedantic tsimbalar/horizontal_blocked_scroll_physics
2 participants
@tsimbalar @robertohuertasm