Stop relying on internal functions #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please accept this PR? Thanks! |
|
cc @fundon |
|
I'd love to have NPM owner and collaborator status if it helps to maintain this package! |
|
Sorry to reply you so late |
|
Can you make a tag that uses latest alpha 2.0.0 of multer On Oct 2, 2016 10:30 PM, "Fangdun Cai" notifications@github.com wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed
_makeMiddlewarein multer 2.0.0-alpha.1 which broke this module. With this patch we aren't relying on any internal functions, but are instead using only the public api.