-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps, use npm scripts, add coverage #54
Conversation
@stiang I've noticed that a lot of pull requests have built up that either update the deps or move over to current NodeJS compatible ES6 syntax. Would you like me to make the ES6 edits? Merging this will then be able to close 3 other pulls. |
cc @stiang @tejasmanohar I don't mean to be impatient or picky, but this is a very popular repo (according to NPM), and I feel that it could benefit from some updates. |
@@ -101,3 +101,6 @@ function resolveCookies(ctx, opts) { | |||
return ctx.cookies.get(opts.cookie); | |||
} | |||
} | |||
|
|||
// Export JWT as a convenience | |||
module.exports.jwt = require('jsonwebtoken'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's mentioned in the docs: a9353a1#diff-04c6e90faac2675aa89e2176d2eec7d8L190. I can remove it if you'd like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tejasmanohar removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The purpose of the convenience function is to provide the matching JWT version for signing tokens. Otherwise an extra library is required on the user end, and koa-jwt doesn't provide all of the methods necessary to use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair
@stiang @jonathanong can you publish / give me access to? this pr was sitting open for a while so i wanted to address it but looks like i don't have access |
@tejasmanohar thanks! |
@tejasmanohar Thanks for stepping up! I basically have no time to maintain this at the moment, so it’s great that you take responsibility. I believe I have published the latest changes as 2.1.0 using the
Let me know if this didn’t work as expected. As for publishing rights, should I just add you as an owner in npm? What email should I use? @DaAwesomeP Thanks for the PR and for mildly nagging us to get it merged :) Sorry about the delay! |
@stiang You can add me as me@tejas.io or tejasmanohar on NPM, but frankly, I'm also fine without publishing rights, as I barely use Koa or Node anymore so probably am not in a good position to maintain this. It just disappointed me to see no one answering the PR for a while so I did :P |
Hi @stiang, thanks for giving me push rights earlier also. I use node and koa daily across several projects. I'm happy to help out with npm publishing as well if you like, i'm on there as https://www.npmjs.com/~sc0ttyd |
package.json
and repolib
folder as was specified inpackage.json