test: fix body test #1375
Merged
test: fix body test #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov Report
@@ Coverage Diff @@
## master #1375 +/- ##
======================================
Coverage 100% 100%
======================================
Files 4 4
Lines 379 379
======================================
Hits 379 379Continue to review full report at Codecov.
|
|
What‘s the real problem this pull request fixed? |
|
The test depends on ‘end’ being emitted. However, since the content length doesn’t match node will emit ‘aborted’. I’m future version of node, end will not be emitted after aborted (that’s a bug). |
dead-horse
reviewed
Aug 23, 2019
Setting body will set the content-length header. Unless the corresponding number of bytes are sent the response will be aborted and not emit 'end'.
ronag
force-pushed
the
fix-respond-test
branch
from
d01e7d9
to
23f9a93
Compare
dead-horse
approved these changes
Aug 23, 2019
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting body will set the content-length header. Unless the
corresponding number of bytes are sent the response will
be aborted and not emit 'end'.