Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ESLint and plugins/configs #1407

Merged
merged 3 commits into from
Oct 17, 2019
Merged

update ESLint and plugins/configs #1407

merged 3 commits into from
Oct 17, 2019

Conversation

tinovyatkin
Copy link
Contributor

@tinovyatkin tinovyatkin commented Oct 16, 2019

  1. Updates ESLint to the version 6.5.x
  2. Updates eslint-config-standard to the version 14.x from 7.x. It brings two more required peerDependencies, eslint-plugin-import and eslint-plugin-node, and the last one if very helpful with Koa tricky engines
  3. Add explicit extension to the eslint config for tests, lowering newly discovered errors to warning for now, and fixing env from jest to mocha
  4. Fixing lint errors in benchmark.

@tinovyatkin tinovyatkin changed the title fix lint errors update ESLint and plugins/configs Oct 16, 2019
@codecov
Copy link

codecov bot commented Oct 16, 2019

Codecov Report

Merging #1407 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1407   +/-   ##
=======================================
  Coverage   99.36%   99.36%           
=======================================
  Files           4        4           
  Lines         474      474           
  Branches      125      125           
=======================================
  Hits          471      471           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be7d334...c0a1cd9. Read the comment docs.

@dead-horse dead-horse merged commit 4dc56f6 into koajs:master Oct 17, 2019
@tinovyatkin tinovyatkin deleted the update-eslint branch October 17, 2019 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants