Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: can not get currentContext in error handler #1757

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

gxkl
Copy link
Contributor

@gxkl gxkl commented Apr 12, 2023

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@zhaozeq

This comment was marked as abuse.

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.96 ⚠️

Comparison is base (34519d1) 99.61% compared to head (5747938) 98.66%.

❗ Current head 5747938 differs from pull request most recent head 933c837. Consider uploading reports for the commit 933c837 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             v2.x    #1757      +/-   ##
==========================================
- Coverage   99.61%   98.66%   -0.96%     
==========================================
  Files           5        5              
  Lines         521      523       +2     
  Branches      145      146       +1     
==========================================
- Hits          519      516       -3     
- Misses          2        7       +5     
Impacted Files Coverage Δ
lib/application.js 94.77% <100.00%> (-3.71%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fengmk2 fengmk2 added the bug label Apr 12, 2023
@fengmk2 fengmk2 merged commit 6b60fa6 into koajs:v2.x Apr 12, 2023
@fengmk2
Copy link
Member

fengmk2 commented Apr 12, 2023

  • koa@2.14.2

@gxkl gxkl deleted the fix/current-context-in-error-handler branch April 12, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants