Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using as.tibble() results in warning #101

Closed
juliasilge opened this issue May 20, 2020 · 2 comments
Closed

Using as.tibble() results in warning #101

juliasilge opened this issue May 20, 2020 · 2 comments

Comments

@juliasilge
Copy link

Thank you so much for your work on this fantastic package! 🙌

Using as.tibble() as in this line:

vip/R/vi_model.R

Line 1322 in bb6294c

vis <- tibble::as.tibble(imp)[, c("feature", type)]

results in warnings such as this after users call vip():

Warning message:
`as.tibble()` is deprecated as of tibble 2.0.0.
Please use `as_tibble()` instead.
The signature and semantics have changed, see `?as_tibble`.
@bradleyboehmke
Copy link
Member

Thanks @juliasilge! This has been updated in the issue101 branch and will be merged into master once @bgreenwell OKs.

@juliasilge
Copy link
Author

Sounds great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants