Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add color_words and color_array to plot_text_comparison #6

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

apjanco
Copy link
Contributor

@apjanco apjanco commented Nov 15, 2023

This request adds the color_words and color_array arguments from plot_text and adds them to plot_text_comparison. This makes it possible to highlight words and classes in two vector spaces.

@koaning
Copy link
Owner

koaning commented Nov 24, 2023

Just wanted to mention that it is my intention to merge this, but family life is taking up a lot of time. Will ping once I've given this a spin!

@koaning koaning merged commit 40bc230 into koaning:main Jul 16, 2024
1 check passed
@koaning
Copy link
Owner

koaning commented Jul 16, 2024

The colors dont work well with the selection mechanism, but I am pragmatic with this library nowadays so I will add the feature and worry about fixing the selection bit if people start to complain about it.

So many libraries ... so little time ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants