Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] add log_dtypes to pandas_utils #99

Closed
koaning opened this issue Apr 3, 2019 · 6 comments
Closed

[FEATURE] add log_dtypes to pandas_utils #99

koaning opened this issue Apr 3, 2019 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@koaning
Copy link
Owner

koaning commented Apr 3, 2019

I might also want to log the dtypes between each step in a pandas pipeline. It's probably best to add a separate logger for both the dtype as well as the shape.

Should the column names be seperate too? Maybe worth a discussion.

It would also be nice if these features were documented on the documentation page together with some other pandas_utils functions.

@koaning koaning added enhancement New feature or request good first issue Good for newcomers labels Apr 3, 2019
@koaning
Copy link
Owner Author

koaning commented Apr 3, 2019

After thinking about it, we probably want to have these three:

  • log_shape
  • log_names
  • log_dtypes

Note too sure about log_names and log_dtypes.

koaning pushed a commit that referenced this issue Aug 23, 2019
light-weight, param-driven implementation of parallelism using multiproc
@david26694
Copy link
Contributor

Is this still open? I'd be happy to take it

@koaning
Copy link
Owner Author

koaning commented Jul 17, 2020

It is still open, but let's first make sure we're clear on what will get implemented. Do you want to implement log_dtypes or also log_names?

Relevant: there's a related issue too #371.

@david26694
Copy link
Contributor

I was thinking about both. I don't fully understand what is happening in #371, why is matplotlib generating warnings and what would the print step do?

@koaning
Copy link
Owner Author

koaning commented Jul 18, 2020

The print step would do a very similar thing to what log_step would do but it would use print instead of using the python logging framework. The reason why matplotlib is generating warnings is because we've configured a logger to work in the notebook. This allows you to receive logs from log_step (this is awesome for production) but you might also get the logs from other libraries (which is not awesome in a notebook).

@koaning
Copy link
Owner Author

koaning commented Sep 22, 2020

This got adressed.

@koaning koaning closed this as completed Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants