Fix pulse update on backend removal #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No change in functional behaviour. Document existing behaviour via tests.
Remove the pulse info from the stash when a backend is removed. This is to avoid the scenario where an unhealthy backend stored remains unhealthy after being scaled down and up again. In this case the pulse update had no effect as the removed backend was still found in the stash.
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
==========================================
+ Coverage 33.39% 39.41% +6.01%
==========================================
Files 18 18
Lines 1018 1030 +12
==========================================
+ Hits 340 406 +66
+ Misses 656 594 -62
- Partials 22 30 +8
Continue to review full report at Codecov.
|
|
@kobolog would you mind taking a look? |
|
Looks good! |
|
Thanks for the good work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the pulse info from the
stashwhen a backend is removed.This is to avoid the scenario where an unhealthy backend stored in the
stashremainsunhealthy after being scaled down and up again.
In this case the pulse update had no effect as the removed backend was
still found in the
stash.Fix made in 2 commits to better visualise the actual change in behaviour