Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure xml_hash is not null and stop doing full-text search #843

Closed
3 tasks
jnm opened this issue Aug 16, 2022 · 1 comment
Closed
3 tasks

Ensure xml_hash is not null and stop doing full-text search #843

jnm opened this issue Aug 16, 2022 · 1 comment
Assignees
@jnm
Labels
backend

Comments

@jnm
Copy link
Member

jnm commented Aug 16, 2022 •
edited
Loading

  • add data migration
  • enforce uniqueness on xml_hash?
  • get rid of this full-text search:

    kobocat/onadata/libs/utils/logger_tools.py

    Lines 165 to 168 in c7e9cf0

    existing_instance = Instance.objects.filter(
    Q(xml_hash=xml_hash) | Q(xml_hash=Instance.DEFAULT_XML_HASH, xml=xml),
    xform__user=xform.user,
    ).first()
@jnm jnm self-assigned this Aug 16, 2022
@jnm jnm removed the high priority label Jan 23, 2023
@noliveleger
Copy link
Contributor

Closed because it is handled by kobotoolbox/kpi#5047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnm jnm

Labels
backend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jnm @noliveleger